Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: checks for non-assignable policy types to allow course search #896

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

brobro10000
Copy link
Member

Checks policy types within redeemableLearnerCreditPolicies for whether a non-assignable redeemable policy exist, if so, return false for isDisableCourseSearch.

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

Copy link

codecov bot commented Dec 12, 2023

Codecov Report

Attention: 108 lines in your changes are missing coverage. Please review.

Comparison is base (d36b78a) 84.87% compared to head (e3c185a) 85.20%.
Report is 98 commits behind head on master.

Files Patch % Lines
...ntent/course-enrollments/CourseAssignmentAlert.jsx 27.27% 8 Missing ⚠️
src/components/course/data/hooks.jsx 88.13% 7 Missing ⚠️
...course-enrollments/course-cards/BaseCourseCard.jsx 89.85% 7 Missing ⚠️
src/components/my-career/VisualizeCareer.jsx 74.07% 6 Missing and 1 partial ⚠️
src/components/my-career/data/service.js 56.25% 7 Missing ⚠️
src/components/course/data/utils.jsx 95.89% 6 Missing ⚠️
src/components/my-career/AddJobRole.jsx 60.00% 5 Missing and 1 partial ⚠️
src/components/my-career/data/hooks.jsx 50.00% 6 Missing ⚠️
...n-content/course-enrollments/CourseEnrollments.jsx 84.37% 5 Missing ⚠️
...components/enterprise-user-subsidy/data/service.js 0.00% 5 Missing ⚠️
... and 26 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #896      +/-   ##
==========================================
+ Coverage   84.87%   85.20%   +0.33%     
==========================================
  Files         320      336      +16     
  Lines        6399     7029     +630     
  Branches     1552     1722     +170     
==========================================
+ Hits         5431     5989     +558     
- Misses        941     1009      +68     
- Partials       27       31       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brobro10000 brobro10000 merged commit ff50628 into master Dec 12, 2023
5 checks passed
@brobro10000 brobro10000 deleted the hu/ent-8128 branch December 12, 2023 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants