Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Migrate deprecated Paragon components #1158

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

zwidekalanga
Copy link
Contributor

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)
  • Ensure English strings are marked for translation. See documentation for more details.

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

Screenshot

Screenshot 2024-08-19 at 11 04 59 PM Screenshot 2024-08-19 at 11 05 14 PM Screenshot 2024-08-19 at 11 05 44 PM Screenshot 2024-08-19 at 11 10 46 PM

@zwidekalanga zwidekalanga force-pushed the zwidekalanga/ENT-9104 branch 3 times, most recently from 44067f2 to ab579c0 Compare August 21, 2024 09:37
Copy link

codecov bot commented Aug 21, 2024

Codecov Report

Attention: Patch coverage is 89.47368% with 2 lines in your changes missing coverage. Please review.

Project coverage is 88.12%. Comparing base (036db74) to head (d1f19c2).
Report is 7 commits behind head on master.

Files Patch % Lines
...course-cards/email-settings/EmailSettingsModal.jsx 66.66% 1 Missing ⚠️
...t/course-enrollments/tests/enrollment-testutils.js 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1158      +/-   ##
==========================================
+ Coverage   88.06%   88.12%   +0.05%     
==========================================
  Files         394      394              
  Lines        8348     8372      +24     
  Branches     2054     2059       +5     
==========================================
+ Hits         7352     7378      +26     
+ Misses        953      951       -2     
  Partials       43       43              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zwidekalanga zwidekalanga force-pushed the zwidekalanga/ENT-9104 branch from ab579c0 to d1f19c2 Compare August 23, 2024 06:53
@adamstankiewicz adamstankiewicz merged commit 17f426a into openedx:master Aug 26, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants