-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: refactor groups alert logic to use credits_available api #1094
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1094 +/- ##
==========================================
- Coverage 86.00% 85.99% -0.01%
==========================================
Files 381 378 -3
Lines 7795 7754 -41
Branches 1867 1897 +30
==========================================
- Hits 6704 6668 -36
+ Misses 1037 1032 -5
Partials 54 54 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great! Thanks for tackling it. Tested it locally and seems to function as expected :) I left a few nits and minor suggestions for your consideration.
src/components/dashboard/main-content/course-enrollments/CourseEnrollments.jsx
Outdated
Show resolved
Hide resolved
src/components/dashboard/main-content/course-enrollments/CourseEnrollmentsEmptyState.jsx
Outdated
Show resolved
Hide resolved
src/components/dashboard/main-content/course-enrollments/data/hooks.js
Outdated
Show resolved
Hide resolved
src/components/dashboard/main-content/course-enrollments/data/hooks.js
Outdated
Show resolved
Hide resolved
src/components/dashboard/main-content/course-enrollments/data/hooks.js
Outdated
Show resolved
Hide resolved
src/components/dashboard/main-content/course-enrollments/data/hooks.js
Outdated
Show resolved
Hide resolved
src/components/dashboard/main-content/course-enrollments/data/hooks.js
Outdated
Show resolved
Hide resolved
src/components/dashboard/main-content/course-enrollments/data/hooks.js
Outdated
Show resolved
Hide resolved
src/components/dashboard/main-content/course-enrollments/data/hooks.js
Outdated
Show resolved
Hide resolved
628a614
to
0dc6f35
Compare
For all changes
Updates the fetch logic for a new groups alert to use the
credits_available
apihttps://2u-internal.atlassian.net/browse/ENT-9010
Only if submitting a visual change