Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactor groups alert logic to use credits_available api #1094

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

katrinan029
Copy link
Contributor

For all changes

Updates the fetch logic for a new groups alert to use the credits_available api
https://2u-internal.atlassian.net/browse/ENT-9010

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)
  • Ensure English strings are marked for translation. See documentation for more details.

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

@katrinan029 katrinan029 requested review from adamstankiewicz and a team June 13, 2024 21:06
Copy link

codecov bot commented Jun 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.99%. Comparing base (b533813) to head (0dc6f35).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1094      +/-   ##
==========================================
- Coverage   86.00%   85.99%   -0.01%     
==========================================
  Files         381      378       -3     
  Lines        7795     7754      -41     
  Branches     1867     1897      +30     
==========================================
- Hits         6704     6668      -36     
+ Misses       1037     1032       -5     
  Partials       54       54              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@adamstankiewicz adamstankiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great! Thanks for tackling it. Tested it locally and seems to function as expected :) I left a few nits and minor suggestions for your consideration.

@katrinan029 katrinan029 merged commit 29a0edb into master Jun 17, 2024
6 of 7 checks passed
@katrinan029 katrinan029 deleted the knguyen2/ent-9010 branch June 17, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants