Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Conditionally render expiring learner credit alerts and modals #1081

Merged
merged 6 commits into from
May 22, 2024

Conversation

brobro10000
Copy link
Member

@brobro10000 brobro10000 commented May 15, 2024

Screen.Recording.2024-05-15.at.11.07.05.AM.mov

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)
  • Ensure English strings are marked for translation. See documentation for more details.

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

Copy link

codecov bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.02%. Comparing base (28f164b) to head (d48b629).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1081      +/-   ##
==========================================
+ Coverage   86.00%   86.02%   +0.01%     
==========================================
  Files         381      381              
  Lines        7759     7770      +11     
  Branches     1893     1896       +3     
==========================================
+ Hits         6673     6684      +11     
  Misses       1032     1032              
  Partials       54       54              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brobro10000 brobro10000 force-pushed the hu/ent-8917 branch 3 times, most recently from 78c868d to e6f43a0 Compare May 17, 2024 13:24
Copy link
Member

@adamstankiewicz adamstankiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I did flag an (existing) issue with the badge status label essentially resulting in an empty i18n message when running npm run i18n_extract. I defer to you whether you'd like to address that in this PR; otherwise, we could consider flagging it to Markhors since they are working on the i18n stuff.

@brobro10000 brobro10000 merged commit 2a50e8a into master May 22, 2024
7 checks passed
@brobro10000 brobro10000 deleted the hu/ent-8917 branch May 22, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants