-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Conditionally render expiring learner credit alerts and modals #1081
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1081 +/- ##
==========================================
+ Coverage 86.00% 86.02% +0.01%
==========================================
Files 381 381
Lines 7759 7770 +11
Branches 1893 1896 +3
==========================================
+ Hits 6673 6684 +11
Misses 1032 1032
Partials 54 54 ☔ View full report in Codecov by Sentry. |
78c868d
to
e6f43a0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I did flag an (existing) issue with the badge status label essentially resulting in an empty i18n message when running npm run i18n_extract
. I defer to you whether you'd like to address that in this PR; otherwise, we could consider flagging it to Markhors since they are working on the i18n stuff.
src/components/dashboard/sidebar/tests/LearnerCreditSummaryCard.test.jsx
Outdated
Show resolved
Hide resolved
src/components/dashboard/sidebar/tests/LearnerCreditSummaryCard.test.jsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Adam Stankiewicz <[email protected]>
Screen.Recording.2024-05-15.at.11.07.05.AM.mov
For all changes
Only if submitting a visual change