Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: migrate license not found to new router #1009

Merged

Conversation

adamstankiewicz
Copy link
Member

@adamstankiewicz adamstankiewicz commented Mar 21, 2024

https://2u-internal.atlassian.net/browse/ENT-8671

Ensures the case covered by #1001 is also handled in the new router.

Refactored slightly to use ErrorPage (which involved extending it to accept optional imageSrc and spannedTitle props). Used proper <ul> for the unordered list.

image

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)
  • Ensure English strings are marked for translation. See documentation for more details.

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

@adamstankiewicz adamstankiewicz marked this pull request as ready for review March 22, 2024 14:27
Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.83%. Comparing base (fda042e) to head (dabf2cb).

Additional details and impacted files
@@                        Coverage Diff                         @@
##           feat/react-query-route-loaders    #1009      +/-   ##
==================================================================
+ Coverage                           80.69%   80.83%   +0.13%     
==================================================================
  Files                                 382      382              
  Lines                                7921     7930       +9     
  Branches                             1941     1948       +7     
==================================================================
+ Hits                                 6392     6410      +18     
+ Misses                               1466     1457       -9     
  Partials                               63       63              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adamstankiewicz adamstankiewicz merged commit 1faeade into feat/react-query-route-loaders Mar 22, 2024
7 checks passed
@adamstankiewicz adamstankiewicz deleted the ags/error-page-subs-activation branch March 22, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants