Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade React JS to v17 #522

Closed
abdullahwaheed opened this issue Jun 26, 2023 · 3 comments
Closed

Upgrade React JS to v17 #522

abdullahwaheed opened this issue Jun 26, 2023 · 3 comments

Comments

@abdullahwaheed
Copy link
Contributor

This repo is currently using React JS v16. We need to upgrade it to React 17 before moving to latest React version(v18).
React 17 doesn’t add any new developer-facing features, so its upgrade might not cause any breaking changes. Our end goal is to upgrade React to v18 but v18 no longer support enzyme, so we are upgrading to React 17 and then we’ll migrate from enzyme.

Epic Link

React 17 upgrade
@jristau1984
Copy link
Contributor

Hi! I am going to close this issue, as 2U will not be considering a react upgrade for a single repo. When Fed-BOM announces that the entire platform will be upgrading to React v18, that is when T&L will move forward with the upgrade.

Feel free to follow up with @adamstankiewicz @davidjoy or @jmbowman for further discussion. Thanks!

@jristau1984 jristau1984 reopened this Jun 26, 2023
@jristau1984
Copy link
Contributor

My knowledge was stale, and Fed-BOM has agreed to pick up this work.

@BilalQamar95 BilalQamar95 mentioned this issue Jun 27, 2023
Merged
@jmbowman
Copy link

It looks like the PR for this was merged, is this done now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jmbowman @jristau1984 @abdullahwaheed