When accessing the Authn MFE first time, It shows "Authn | null" in the header

[hinakhadim]

Whenever I clicked on 'Sign In' button, it takes me to the Authn MFE. The issue is that it shows 'Authn | null' in the header. The reason is that in public/index.html, the header is <title>Authn | <%= process.env.SITE_NAME %></title>. For first time, the process.env.SITE_NAME is null and after that mergeConfig runs which updates SITE_NAME. Due to that thing, it shows Authn | null which is not a good user experience. I will suggest to remove | <%= process.env.SITE_NAME %> and its better to just show Authn only in title. Here is the screenshot:

I am running openedx using tutor local

[regisb]

Hi Hina! 👋 Removing the entire | <%= process.env.SITE_NAME %> is going to be a breaking change for every Open edX platform out there, and a very debatable one.

Can I suggest instead to only remove the site name when it's null? That way, the title would be "Authn" while loading the page, and then become "Authn | site_name" once mergeConfig is run. Is that even possible?

A separate question would be to rename the "Authn" title to "Authentication". I think there's consensus to say that "Authn" makes for a terrible site name.

[attiyaIshaque]

@hinakhadim The issue has been resolved in Pull Request #1168, and I am closing the PR with the resolution of "Fixed."

[attiyaIshaque]

@regisb I have implemented this suggested change.

Can I suggest instead to only remove the site name when it's null? That way, the title would be "Authn" while loading the page, and then become "Authn | site_name" once mergeConfig is run. Is that even possible?

[zainab-amir]

I think there's consensus to say that "Authn" makes for a terrible site name.

I agree. I'll confirm from product and then @attiyaIshaque lets create a follow up PR to do this too.

[regisb]

Oh wow. Simple and efficient, I love it! Feel free to open a similar PR to cherry-pick the change in the open-release/quince.master branch. That way we will benefit from this change the next time a minor release tag is created (should be some time around april, I believe).

[hinakhadim]

Hi all, I have tested the fixed PR #1168 on my machine. It haven't resolved the issue for me. It treats null as string and pass the condition which should be failed. I have created another PR #1185. I kindly request your assistance in reviewing this latest submission.