Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: updates groups page to show only flex groups for customer #1384

Merged
merged 2 commits into from
Jan 16, 2025

Conversation

katrinan029
Copy link
Contributor

@katrinan029 katrinan029 commented Jan 15, 2025

Description

Fixes bug on the People Management view that is currently displaying all groups (both flex and budget) to all customers. The behavior we want is to only show flex groups that were created by that customer.

Screenshot 2025-01-15 at 3 24 17 PM

Screenshot 2025-01-15 at 3 24 42 PM

https://2u-internal.atlassian.net/browse/ENT-9913

Testing instructions

  1. check out this branch locally and run npm run start:stage
  2. visit link https://localhost.stage.edx.org:1991/aj-test-co/admin/people-management and confirm that you do not see any group cards displayed. Ensure that you also do not see any results from this endpoint https://courses.stage.edx.org/enterprise/api/v1/enterprise_group/?enterprise_uuids=e035cce5-24dd-4be4-896d-497157c09a39. Lastly, confirm that there are no flex groups for that customer here https://internal.courses.stage.edx.org/admin/enterprise/enterprisegroup/
  3. Repeat the steps above for a second customer (e.g. adam-autoapplied-enterprise)

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

@katrinan029 katrinan029 marked this pull request as ready for review January 15, 2025 23:25
@katrinan029 katrinan029 merged commit c13ed49 into master Jan 16, 2025
4 of 6 checks passed
@katrinan029 katrinan029 deleted the knguyen2/ent-9913 branch January 16, 2025 01:31
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 42.85714% with 4 lines in your changes missing coverage. Please review.

Project coverage is 85.83%. Comparing base (482781d) to head (ba0f6c4).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...anagement/data/hooks/useAllFlexEnterpriseGroups.js 33.33% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1384      +/-   ##
==========================================
- Coverage   85.83%   85.83%   -0.01%     
==========================================
  Files         624      624              
  Lines       13635    13642       +7     
  Branches     2850     2860      +10     
==========================================
+ Hits        11703    11709       +6     
- Misses       1862     1863       +1     
  Partials       70       70              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants