Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adding toast after deleting a group #1383

Merged
merged 9 commits into from
Jan 16, 2025
Merged

fix: adding toast after deleting a group #1383

merged 9 commits into from
Jan 16, 2025

Conversation

kiram15
Copy link
Contributor

@kiram15 kiram15 commented Jan 14, 2025

Screen.Recording.2025-01-14.at.3.52.15.PM.mov

Jira ticket

Testing

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

@kiram15 kiram15 requested a review from a team January 14, 2025 22:53
@@ -39,7 +39,7 @@ const GroupCardGrid = ({ groups }) => {
lg: 6,
xl: 4,
}}
hasEqualColumnHeights="true"
hasEqualColumnHeights
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was giving a warning, I fixed it but it's unrelated to this ticket

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.90%. Comparing base (bd082d3) to head (8334bd1).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1383      +/-   ##
==========================================
+ Coverage   85.84%   85.90%   +0.05%     
==========================================
  Files         627      627              
  Lines       13697    13705       +8     
  Branches     2874     2872       -2     
==========================================
+ Hits        11758    11773      +15     
+ Misses       1869     1863       -6     
+ Partials       70       69       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kiram15 kiram15 merged commit d7e8a8d into master Jan 16, 2025
6 checks passed
@kiram15 kiram15 deleted the kiram15/ENT-9860 branch January 16, 2025 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants