Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Updated completions and engagements tabs in analytics according to performance enhancement updates on the backend. #1315

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

saleem-latif
Copy link
Contributor

Jira Tickets: ENT-9433, ENT-9434

Updated completions and engagements tabs in analytics according to performance enhancement updates on the backend.

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

@saleem-latif saleem-latif self-assigned this Sep 23, 2024
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 86.66667% with 8 lines in your changes missing coverage. Please review.

Project coverage is 85.57%. Comparing base (aefd6bd) to head (3401429).
Report is 9 commits behind head on master.

Files with missing lines Patch % Lines
...yticsV2/data/hooks/useEnterpriseCompletionsData.js 84.21% 3 Missing ⚠️
...lyticsV2/data/hooks/useEnterpriseEngagementData.js 84.21% 3 Missing ⚠️
...components/AdvanceAnalyticsV2/tabs/Completions.jsx 90.90% 1 Missing ⚠️
...components/AdvanceAnalyticsV2/tabs/Engagements.jsx 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1315      +/-   ##
==========================================
- Coverage   85.58%   85.57%   -0.01%     
==========================================
  Files         568      570       +2     
  Lines       12608    12666      +58     
  Branches     2638     2690      +52     
==========================================
+ Hits        10790    10839      +49     
- Misses       1757     1765       +8     
- Partials       61       62       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@saleem-latif saleem-latif merged commit b8cd0c7 into master Sep 23, 2024
6 checks passed
@saleem-latif saleem-latif deleted the saleem-latif/ENT-9434 branch September 23, 2024 12:06
@muhammad-ammar muhammad-ammar added the plotly-migration Work to migrate from Plotly DASH to PlotlyJS label Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plotly-migration Work to migrate from Plotly DASH to PlotlyJS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants