Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adding assignment uuid to event #1309

Merged
merged 4 commits into from
Sep 19, 2024
Merged

fix: adding assignment uuid to event #1309

merged 4 commits into from
Sep 19, 2024

Conversation

kiram15
Copy link
Contributor

@kiram15 kiram15 commented Sep 18, 2024

Jira ticket - adding in a prop of "assignmentUuid" aka learner content assignment uuid into the metadata sent with the edx.ui.enterprise.admin_portal.learner_credit_management.budget_detail.activity.assigned_table_remind.clicked segment event

Screenshot 2024-09-17 at 5 53 27 PM

Corresponding assignment record

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

@kiram15 kiram15 requested a review from a team September 18, 2024 00:10
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.57%. Comparing base (46203b8) to head (e650dbe).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1309   +/-   ##
=======================================
  Coverage   85.57%   85.57%           
=======================================
  Files         568      568           
  Lines       12607    12607           
  Branches     2679     2673    -6     
=======================================
  Hits        10789    10789           
+ Misses       1757     1756    -1     
- Partials       61       62    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kiram15 kiram15 merged commit 29cf821 into master Sep 19, 2024
4 checks passed
@kiram15 kiram15 deleted the kiram15/ENT-9451 branch September 19, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants