Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update Django constraint to match latest LTS version #403

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

mariajgrimaldi
Copy link
Member

@mariajgrimaldi mariajgrimaldi commented Feb 27, 2024

Description:

This PR updates the Django common constraint used by other projects' repositories to use the latest LTS version: https://openedx.atlassian.net/wiki/spaces/AC/pages/3767926815/Django+4.2+Upgrade+Plan

Merge checklist:

  • All reviewers approved
  • CI build is green
  • If adding new checks, followed how_tos/0001-adding-new-checks.rst
  • Changelog record added (if needed) NA
  • Documentation updated (not only docstrings) (if needed) NA
  • Commits are squashed

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Feb 27, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @mariajgrimaldi! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@mphilbrick211
Copy link

@feanil - is this something Axim should review?

@feanil
Copy link
Contributor

feanil commented Feb 28, 2024

Yea, there are still 2 services that are not running django 4 so we'll need to update the local constraints for those services so we can merge this, I'll reach out to the team that's doing the upgrades for those final 2 services.

@feanil feanil self-requested a review February 28, 2024 15:04
@feanil feanil self-assigned this Feb 28, 2024
@feanil feanil requested review from UsamaSadiq and removed request for feanil February 28, 2024 16:35
@feanil feanil removed their assignment Feb 28, 2024
@UsamaSadiq UsamaSadiq merged commit e25b51b into openedx:master Feb 29, 2024
4 checks passed
@openedx-webhooks
Copy link

@mariajgrimaldi 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants