[GH Request] course-discovery access revoke for 2U Inspire squad

[DawoudSheraz]

Firm Name

2U

Urgency

High (< 3 days)

Requested Change

Hello. Referring https://docs.google.com/spreadsheets/d/1li0HLco8BlHiWoG7oGdslbqeMirgp11nRDNrJsHY5n8/edit?gid=1897338731#gid=1897338731, it seems Inspire/Phoenix (2u-phoenix/course-discovery-maintainers) has lost write access to course-discovery.
I can't recall exactly if/when course-discovery was removed from retainsherip tab from the above sheet, though it is not present in the repo permission removal tab either). We do have merge/write access for publisher. Please fix the issue and provide us the write access back.

Reasoning

I don't think the revoke was an expected behavior, especially for course-discovery whose DEPR has been up for a while. course-discovery is an integral component of 2U business and we would like to retain the write access, just like we have it for publisher.

[github-actions]

Thank you for your report! @openedx/axim-oncall will triage within a business day. Simple requests usually take 2-3 business days to resolve; more complex requests could take longer.

[feanil]

Hi @DawoudSheraz the reason it wasn't on the list was because it looks like it was removed from the 2u-edx-legacy access a while ago. However, the team listed in the repo does not exist anymore. If the 2u-hpeonix team is meant to be the maintainers, please update the catalog-info.yaml file to indicate that. Once that's done, I can fix up the permissions so that anyone on that github team is made a core-contributor on that repo and is granted write access.

Let me know when the updates are made and I can apply the changes to permissions on my side.

[DawoudSheraz]

Created PR openedx/course-discovery#4579 for updating the catalog-info. Please review and merge.

the reason it wasn't on the list was because it looks like it was removed from the 2u-edx-legacy access a while ago.

What was the reason for this? Removing extra teams?

[feanil]

the reason it wasn't on the list was because it looks like it was removed from the 2u-edx-legacy access a while ago.

What was the reason for this? Removing extra teams?

This is a guess but this was probably an approach we tried in the earlier iterations of the maintainer program.

In any case, I've added the current 2u-phoenix team members as core contributors on that repo and they should have their write access back. I've also added the 2u-phoenix team back to the repo with read access so it can get tagged on PRs and reviews.

I also noticed that there is a course-discovery-maintainers which looks to be slightly out of date and was probably used previously for access and is still getting tagged on requirement upgrade PRs, you probably want to upgrade the relevant workflow for consistency.

This issue should be all set now.

[DawoudSheraz]

Thanks for the assistance on this, @feanil . The access issue has been resolved. Thanks
We will update the relevant workflow to use 2u-phoenix instead of the maintainers team.