This repository has been archived by the owner on Nov 4, 2024. It is now read-only.
Unified Order History for Ecommerce and Commercetools #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now mostly trust the server and if its a pure decimal number, we assume its USD (this is to support legacy system)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2u/replatforming #370 +/- ##
===================================================
Coverage ? 63.09%
===================================================
Files ? 34
Lines ? 317
Branches ? 68
===================================================
Hits ? 200
Misses ? 112
Partials ? 5 ☔ View full report in Codecov by Sentry. |
shafqatfarhan
approved these changes
Feb 7, 2024
grmartin
commented
Feb 7, 2024
| @@ -76,7 +51,7 @@ export async function getOrders(page = 1, pageSize = 20) { | |||
|
|
|||
| return { | |||
| datePlaced: date_placed, // eslint-disable-line camelcase | |||
| total: total_excl_tax, // eslint-disable-line camelcase | |||
| total: isNotDecimalish(total_excl_tax) ? total_excl_tax : `$${total_excl_tax}`, // eslint-disable-line camelcase | |||
There was a problem hiding this comment.
The Legacy Ecomm system works in USD, the modern does Remote Currency formatting. Thus we could get bacl $12.34 AUD instead of 12.34.
grmartin
deleted the
grmartin/SONIC-126-unified_order_history_for_faecomm
branch
grmartin
added a commit
that referenced
this pull request
Apr 2, 2024
* feat: Unified order history * fix: number formatting issues for order history table We now mostly trust the server and if its a pure decimal number, we assume its USD (this is to support legacy system) * fix: npx update-browserslist-db@latest --- Author: Glenn R. Martin <[email protected]> Date: Wed Feb 7 05:30:57 2024 -0500 On branch 2u/replatform-to-master You are currently cherry-picking commit bb939ff. Changes to be committed: modified: .env.development modified: .env.test modified: src/order-history/OrderHistoryPage.jsx modified: src/order-history/service.js
grmartin
added a commit
that referenced
this pull request
Apr 2, 2024
* feat: Unified order history * fix: number formatting issues for order history table We now mostly trust the server and if its a pure decimal number, we assume its USD (this is to support legacy system) * fix: npx update-browserslist-db@latest --- Author: Glenn R. Martin <[email protected]> Date: Wed Feb 7 05:30:57 2024 -0500 On branch 2u/replatform-to-master You are currently cherry-picking commit bb939ff. Changes to be committed: modified: .env.development modified: .env.test modified: src/order-history/OrderHistoryPage.jsx modified: src/order-history/service.js
grmartin
added a commit
that referenced
this pull request
Apr 2, 2024
* feat: Unified order history * fix: number formatting issues for order history table We now mostly trust the server and if its a pure decimal number, we assume its USD (this is to support legacy system) * fix: npx update-browserslist-db@latest --- Author: Glenn R. Martin <[email protected]> Date: Wed Feb 7 05:30:57 2024 -0500 On branch 2u/replatform-to-master You are currently cherry-picking commit bb939ff. Changes to be committed: modified: .env.development modified: .env.test modified: src/order-history/OrderHistoryPage.jsx modified: src/order-history/service.js
grmartin
added a commit
that referenced
this pull request
Apr 2, 2024
* feat: Unified Order History for Ecommerce and Commercetools (#370) * feat: Unified order history * fix: number formatting issues for order history table We now mostly trust the server and if its a pure decimal number, we assume its USD (this is to support legacy system) * fix: npx update-browserslist-db@latest --- Author: Glenn R. Martin <[email protected]> Date: Wed Feb 7 05:30:57 2024 -0500 On branch 2u/replatform-to-master You are currently cherry-picking commit bb939ff. Changes to be committed: modified: .env.development modified: .env.test modified: src/order-history/OrderHistoryPage.jsx modified: src/order-history/service.js * feat: Unified Order History Receipt URL (#371) * feat: Unified Order History Receipt URL SONIC-279 * fix: Update .env.development trailing slash is what nginx appends to URLs during routing to the appropriate service. If it is not present, no endpoint would match Co-authored-by: Shafqat Farhan <[email protected]> --------- Co-authored-by: Shafqat Farhan <[email protected]> * feat: Uniform order history for CC's Unified Order History as well as Legacy (#377) * feat: Optionally triggered Legacy vs Unified order history * fix: URL Pathing to enable OSS to function a bit simpler with a better fallback, based on Shafqat's feedback --------- Co-authored-by: Shafqat Farhan <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SONIC-126
THIS DIVERGES FROM MAIN/MASTER