From a80f802d07eab16b6b38e6a8c1c7f8316384536d Mon Sep 17 00:00:00 2001 From: Sahil Raja Date: Mon, 28 Jun 2021 13:29:12 +0530 Subject: [PATCH 01/12] Add metrics listen address Signed-off-by: Sahil Raja --- deploy/helm/charts/templates/lvm-node.yaml | 7 +++++++ deploy/helm/charts/templates/service.yaml | 6 ++++++ deploy/helm/charts/values.yaml | 1 + 3 files changed, 14 insertions(+) create mode 100644 deploy/helm/charts/templates/service.yaml diff --git a/deploy/helm/charts/templates/lvm-node.yaml b/deploy/helm/charts/templates/lvm-node.yaml index 703502c6..93a943b4 100644 --- a/deploy/helm/charts/templates/lvm-node.yaml +++ b/deploy/helm/charts/templates/lvm-node.yaml @@ -75,6 +75,9 @@ spec: - "--riops-per-gb=$(RIOPS_PER_GB)" - "--wiops-per-gb=$(WIOPS_PER_GB)" {{- end }} + {{- if .Values.lvmNode.metricsListenAddress }} + - "--listenAddress=$(METRICS_LISTEN_ADDRESS)" + {{- end }} env: - name: OPENEBS_NODE_ID valueFrom: @@ -96,6 +99,10 @@ spec: - name: WIOPS_PER_GB value: {{ .Values.lvmPlugin.ioLimits.writeIopsPerGB }} {{- end }} + {{- if .Values.lvmNode.metricsListenAddress }} + - name: METRICS_LISTEN_ADDRESS + value: {{ .Values.lvmNode.metricsListenAddress }} + {{- end }} volumeMounts: - name: plugin-dir mountPath: /plugin diff --git a/deploy/helm/charts/templates/service.yaml b/deploy/helm/charts/templates/service.yaml new file mode 100644 index 00000000..494dff9f --- /dev/null +++ b/deploy/helm/charts/templates/service.yaml @@ -0,0 +1,6 @@ +{{- if .Values.lvmNode.metricsListenAddress }} +apiVersion: v1 +kind: Service +metadata: + +{{- end }} \ No newline at end of file diff --git a/deploy/helm/charts/values.yaml b/deploy/helm/charts/values.yaml index f0da40e2..1a3f464b 100644 --- a/deploy/helm/charts/values.yaml +++ b/deploy/helm/charts/values.yaml @@ -36,6 +36,7 @@ lvmNode: # This can be configured to run on various different k8s distributions like # microk8s where kubelet dir is different kubeletDir: "/var/lib/kubelet/" + metricsListenAddress: :9080 resources: {} # limits: # cpu: 10m From 32403f51e2ce9b92b8753e52bc2e0cc5d52d920b Mon Sep 17 00:00:00 2001 From: Sahil Raja Date: Mon, 28 Jun 2021 14:57:26 +0530 Subject: [PATCH 02/12] Add service yaml Signed-off-by: Sahil Raja --- deploy/helm/charts/README.md | 1 + .../charts/templates/lvm-node-service.yaml | 18 ++++++++++++++++++ deploy/helm/charts/templates/lvm-node.yaml | 6 +++--- deploy/helm/charts/templates/service.yaml | 6 ------ deploy/helm/charts/values.yaml | 5 ++++- 5 files changed, 26 insertions(+), 10 deletions(-) create mode 100644 deploy/helm/charts/templates/lvm-node-service.yaml delete mode 100644 deploy/helm/charts/templates/service.yaml diff --git a/deploy/helm/charts/README.md b/deploy/helm/charts/README.md index 1664ff46..b7a83edb 100644 --- a/deploy/helm/charts/README.md +++ b/deploy/helm/charts/README.md @@ -79,6 +79,7 @@ The following table lists the configurable parameters of the OpenEBS LVM Localpv | `lvmPlugin.image.repository`| Image repository for openebs-lvm-plugin| `openebs/lvm-driver`| | `lvmPlugin.image.pullPolicy`| Image pull policy for openebs-lvm-plugin| `IfNotPresent`| | `lvmPlugin.image.tag`| Image tag for openebs-lvm-plugin| `0.6.0`| +| `lvmPlugin.metricsListenAddress`| The TCP network address where the prometheus metrics endpoint will listen | `9080`| | `lvmNode.driverRegistrar.image.registry`| Registry for csi-node-driver-registrar image| `k8s.gcr.io/`| | `lvmNode.driverRegistrar.image.repository`| Image repository for csi-node-driver-registrar| `sig-storage/csi-node-driver-registrar`| | `lvmNode.driverRegistrar.image.pullPolicy`| Image pull policy for csi-node-driver-registrar| `IfNotPresent`| diff --git a/deploy/helm/charts/templates/lvm-node-service.yaml b/deploy/helm/charts/templates/lvm-node-service.yaml new file mode 100644 index 00000000..b712c4b7 --- /dev/null +++ b/deploy/helm/charts/templates/lvm-node-service.yaml @@ -0,0 +1,18 @@ +{{- if .Values.lvmPlugin.metricsListenAddress }} +apiVersion: v1 +kind: Service +metadata: + name: {{ template "lvmlocalpv.fullname" . }}-node-service + labels: + {{- include "lvmlocalpv.lvmNode.labels" . | nindent 4 }} +spec: + ports: + - name: metrics + port: {{ .Values.lvmPlugin.metricsListenAddress }} + targetPort: {{ .Values.lvmPlugin.metricsListenAddress }} + selector: + {{- with .Values.lvmNode.podLabels }} + {{ toYaml . }} + {{- end }} + type: ClusterIP +{{- end }} \ No newline at end of file diff --git a/deploy/helm/charts/templates/lvm-node.yaml b/deploy/helm/charts/templates/lvm-node.yaml index 93a943b4..138df158 100644 --- a/deploy/helm/charts/templates/lvm-node.yaml +++ b/deploy/helm/charts/templates/lvm-node.yaml @@ -75,7 +75,7 @@ spec: - "--riops-per-gb=$(RIOPS_PER_GB)" - "--wiops-per-gb=$(WIOPS_PER_GB)" {{- end }} - {{- if .Values.lvmNode.metricsListenAddress }} + {{- if .Values.lvmPlugin.metricsListenAddress }} - "--listenAddress=$(METRICS_LISTEN_ADDRESS)" {{- end }} env: @@ -99,9 +99,9 @@ spec: - name: WIOPS_PER_GB value: {{ .Values.lvmPlugin.ioLimits.writeIopsPerGB }} {{- end }} - {{- if .Values.lvmNode.metricsListenAddress }} + {{- if .Values.lvmPlugin.metricsListenAddress }} - name: METRICS_LISTEN_ADDRESS - value: {{ .Values.lvmNode.metricsListenAddress }} + value: :{{ .Values.lvmPlugin.metricsListenAddress }} {{- end }} volumeMounts: - name: plugin-dir diff --git a/deploy/helm/charts/templates/service.yaml b/deploy/helm/charts/templates/service.yaml deleted file mode 100644 index 494dff9f..00000000 --- a/deploy/helm/charts/templates/service.yaml +++ /dev/null @@ -1,6 +0,0 @@ -{{- if .Values.lvmNode.metricsListenAddress }} -apiVersion: v1 -kind: Service -metadata: - -{{- end }} \ No newline at end of file diff --git a/deploy/helm/charts/values.yaml b/deploy/helm/charts/values.yaml index 1a3f464b..e0d69ff0 100644 --- a/deploy/helm/charts/values.yaml +++ b/deploy/helm/charts/values.yaml @@ -36,7 +36,6 @@ lvmNode: # This can be configured to run on various different k8s distributions like # microk8s where kubelet dir is different kubeletDir: "/var/lib/kubelet/" - metricsListenAddress: :9080 resources: {} # limits: # cpu: 10m @@ -133,6 +132,10 @@ lvmPlugin: containerRuntime: containerd readIopsPerGB: "" writeIopsPerGB: "" + # The TCP network address where the prometheus metrics endpoint will listen. + # The default is empty string, which means metrics endpoint is disabled. + # If not set, service will not be created to expose this endpoint to serviceMonitor. + metricsListenAddress: 9080 role: openebs-lvm From 03e392216ba661e5590bbb1a2198830515065c47 Mon Sep 17 00:00:00 2001 From: Sahil Raja Date: Mon, 28 Jun 2021 16:06:58 +0530 Subject: [PATCH 03/12] Chart version bumped Signed-off-by: Sahil Raja --- deploy/helm/charts/Chart.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/deploy/helm/charts/Chart.yaml b/deploy/helm/charts/Chart.yaml index bc373f30..0366bd03 100644 --- a/deploy/helm/charts/Chart.yaml +++ b/deploy/helm/charts/Chart.yaml @@ -1,7 +1,7 @@ apiVersion: v2 name: lvm-localpv description: CSI Driver for dynamic provisioning of LVM Persistent Local Volumes. -version: 0.6.1 +version: 0.6.2 appVersion: 0.6.0 icon: https://raw.githubusercontent.com/cncf/artwork/master/projects/openebs/icon/color/openebs-icon-color.png home: http://www.openebs.io/ From f6e549f226571b387563f3ec0a1b2f67bad7dcbf Mon Sep 17 00:00:00 2001 From: Sahil Raja Date: Mon, 28 Jun 2021 16:11:58 +0530 Subject: [PATCH 04/12] Updated comments Signed-off-by: Sahil Raja --- deploy/helm/charts/values.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/deploy/helm/charts/values.yaml b/deploy/helm/charts/values.yaml index e0d69ff0..5a4d0a78 100644 --- a/deploy/helm/charts/values.yaml +++ b/deploy/helm/charts/values.yaml @@ -134,7 +134,7 @@ lvmPlugin: writeIopsPerGB: "" # The TCP network address where the prometheus metrics endpoint will listen. # The default is empty string, which means metrics endpoint is disabled. - # If not set, service will not be created to expose this endpoint to serviceMonitor. + # If not set, service will not be created to expose this endpoint to serviceMonitor and listen-address flag will not be set. metricsListenAddress: 9080 role: openebs-lvm From 7b9d7cb92b5f98c147005e822257cc664c6ead93 Mon Sep 17 00:00:00 2001 From: Sahil Raja Date: Tue, 29 Jun 2021 12:14:55 +0530 Subject: [PATCH 05/12] Minor fix Signed-off-by: Sahil Raja --- deploy/helm/charts/templates/lvm-node.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/deploy/helm/charts/templates/lvm-node.yaml b/deploy/helm/charts/templates/lvm-node.yaml index 138df158..171a2860 100644 --- a/deploy/helm/charts/templates/lvm-node.yaml +++ b/deploy/helm/charts/templates/lvm-node.yaml @@ -76,7 +76,7 @@ spec: - "--wiops-per-gb=$(WIOPS_PER_GB)" {{- end }} {{- if .Values.lvmPlugin.metricsListenAddress }} - - "--listenAddress=$(METRICS_LISTEN_ADDRESS)" + - "--listen-address=$(METRICS_LISTEN_ADDRESS)" {{- end }} env: - name: OPENEBS_NODE_ID From 708df2a08127fb37ae36c49d4e390cad8660121a Mon Sep 17 00:00:00 2001 From: Sahil Raja Date: Wed, 30 Jun 2021 15:12:28 +0530 Subject: [PATCH 06/12] Changed service to headless service Signed-off-by: Sahil Raja --- deploy/helm/charts/templates/lvm-node-service.yaml | 2 +- deploy/helm/charts/values.yaml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/deploy/helm/charts/templates/lvm-node-service.yaml b/deploy/helm/charts/templates/lvm-node-service.yaml index b712c4b7..2e1953e7 100644 --- a/deploy/helm/charts/templates/lvm-node-service.yaml +++ b/deploy/helm/charts/templates/lvm-node-service.yaml @@ -6,6 +6,7 @@ metadata: labels: {{- include "lvmlocalpv.lvmNode.labels" . | nindent 4 }} spec: + clusterIP: None ports: - name: metrics port: {{ .Values.lvmPlugin.metricsListenAddress }} @@ -14,5 +15,4 @@ spec: {{- with .Values.lvmNode.podLabels }} {{ toYaml . }} {{- end }} - type: ClusterIP {{- end }} \ No newline at end of file diff --git a/deploy/helm/charts/values.yaml b/deploy/helm/charts/values.yaml index 5a4d0a78..5009cbb2 100644 --- a/deploy/helm/charts/values.yaml +++ b/deploy/helm/charts/values.yaml @@ -135,7 +135,7 @@ lvmPlugin: # The TCP network address where the prometheus metrics endpoint will listen. # The default is empty string, which means metrics endpoint is disabled. # If not set, service will not be created to expose this endpoint to serviceMonitor and listen-address flag will not be set. - metricsListenAddress: 9080 + metricsListenAddress: 9500 role: openebs-lvm From 15daf430c1345662c6cd149c4755010834f5129b Mon Sep 17 00:00:00 2001 From: Sahil Raja Date: Wed, 30 Jun 2021 16:08:36 +0530 Subject: [PATCH 07/12] Added flag and service in operator yaml Signed-off-by: Sahil Raja --- deploy/lvm-operator.yaml | 18 ++++++++++++++++++ deploy/yamls/lvm-driver.yaml | 18 ++++++++++++++++++ 2 files changed, 36 insertions(+) diff --git a/deploy/lvm-operator.yaml b/deploy/lvm-operator.yaml index 1c598e7c..75fa5a11 100644 --- a/deploy/lvm-operator.yaml +++ b/deploy/lvm-operator.yaml @@ -1357,6 +1357,7 @@ spec: - "--nodeid=$(OPENEBS_NODE_ID)" - "--endpoint=$(OPENEBS_CSI_ENDPOINT)" - "--plugin=$(OPENEBS_NODE_DRIVER)" + - "--listen-address=$(METRICS_LISTEN_ADDRESS)" env: - name: OPENEBS_NODE_ID valueFrom: @@ -1368,6 +1369,8 @@ spec: value: agent - name: LVM_NAMESPACE value: openebs + - name: METRICS_LISTEN_ADDRESS + value: :9500 volumeMounts: - name: plugin-dir mountPath: /plugin @@ -1396,3 +1399,18 @@ spec: path: /var/lib/kubelet/ type: Directory --- + +apiVersion: v1 +kind: Service +metadata: + name: openebs-lvm-node-service + labels: + name: openebs-lvm-node +spec: + clusterIP: None + ports: + - name: metrics + port: 9500 + targetPort: 9500 + selector: + app: openebs-lvm-node diff --git a/deploy/yamls/lvm-driver.yaml b/deploy/yamls/lvm-driver.yaml index 0dc7f2d2..a70ef014 100644 --- a/deploy/yamls/lvm-driver.yaml +++ b/deploy/yamls/lvm-driver.yaml @@ -988,6 +988,7 @@ spec: - "--nodeid=$(OPENEBS_NODE_ID)" - "--endpoint=$(OPENEBS_CSI_ENDPOINT)" - "--plugin=$(OPENEBS_NODE_DRIVER)" + - "--listen-address=$(METRICS_LISTEN_ADDRESS)" env: - name: OPENEBS_NODE_ID valueFrom: @@ -999,6 +1000,8 @@ spec: value: agent - name: LVM_NAMESPACE value: openebs + - name: METRICS_LISTEN_ADDRESS + value: :9500 volumeMounts: - name: plugin-dir mountPath: /plugin @@ -1027,3 +1030,18 @@ spec: path: /var/lib/kubelet/ type: Directory --- + +apiVersion: v1 +kind: Service +metadata: + name: openebs-lvm-node-service + labels: + name: openebs-lvm-node +spec: + clusterIP: None + ports: + - name: metrics + port: 9500 + targetPort: 9500 + selector: + app: openebs-lvm-node From 33a8382fa10ac0dd94c2862b98d9703dde60c025 Mon Sep 17 00:00:00 2001 From: Sahil Raja Date: Wed, 30 Jun 2021 16:35:24 +0530 Subject: [PATCH 08/12] Updated readme Signed-off-by: Sahil Raja --- deploy/helm/charts/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/deploy/helm/charts/README.md b/deploy/helm/charts/README.md index b7a83edb..23b479c3 100644 --- a/deploy/helm/charts/README.md +++ b/deploy/helm/charts/README.md @@ -79,7 +79,7 @@ The following table lists the configurable parameters of the OpenEBS LVM Localpv | `lvmPlugin.image.repository`| Image repository for openebs-lvm-plugin| `openebs/lvm-driver`| | `lvmPlugin.image.pullPolicy`| Image pull policy for openebs-lvm-plugin| `IfNotPresent`| | `lvmPlugin.image.tag`| Image tag for openebs-lvm-plugin| `0.6.0`| -| `lvmPlugin.metricsListenAddress`| The TCP network address where the prometheus metrics endpoint will listen | `9080`| +| `lvmPlugin.metricsListenAddress`| The TCP network address where the prometheus metrics endpoint will listen | `9500`| | `lvmNode.driverRegistrar.image.registry`| Registry for csi-node-driver-registrar image| `k8s.gcr.io/`| | `lvmNode.driverRegistrar.image.repository`| Image repository for csi-node-driver-registrar| `sig-storage/csi-node-driver-registrar`| | `lvmNode.driverRegistrar.image.pullPolicy`| Image pull policy for csi-node-driver-registrar| `IfNotPresent`| From 7a67130003043aa0c63020b7e360aa43a12c5739 Mon Sep 17 00:00:00 2001 From: Sahil Raja Date: Thu, 1 Jul 2021 10:01:01 +0530 Subject: [PATCH 09/12] Addressed review comment Signed-off-by: Sahil Raja --- deploy/helm/charts/README.md | 2 +- deploy/helm/charts/templates/lvm-node-service.yaml | 6 +++--- deploy/helm/charts/templates/lvm-node.yaml | 6 +++--- deploy/helm/charts/values.yaml | 7 +++---- 4 files changed, 10 insertions(+), 11 deletions(-) diff --git a/deploy/helm/charts/README.md b/deploy/helm/charts/README.md index 23b479c3..4a7d7dc2 100644 --- a/deploy/helm/charts/README.md +++ b/deploy/helm/charts/README.md @@ -79,7 +79,7 @@ The following table lists the configurable parameters of the OpenEBS LVM Localpv | `lvmPlugin.image.repository`| Image repository for openebs-lvm-plugin| `openebs/lvm-driver`| | `lvmPlugin.image.pullPolicy`| Image pull policy for openebs-lvm-plugin| `IfNotPresent`| | `lvmPlugin.image.tag`| Image tag for openebs-lvm-plugin| `0.6.0`| -| `lvmPlugin.metricsListenAddress`| The TCP network address where the prometheus metrics endpoint will listen | `9500`| +| `lvmPlugin.metricsPort`| Port number used for exposing lvm-metrics | `9500`| | `lvmNode.driverRegistrar.image.registry`| Registry for csi-node-driver-registrar image| `k8s.gcr.io/`| | `lvmNode.driverRegistrar.image.repository`| Image repository for csi-node-driver-registrar| `sig-storage/csi-node-driver-registrar`| | `lvmNode.driverRegistrar.image.pullPolicy`| Image pull policy for csi-node-driver-registrar| `IfNotPresent`| diff --git a/deploy/helm/charts/templates/lvm-node-service.yaml b/deploy/helm/charts/templates/lvm-node-service.yaml index 2e1953e7..4825c259 100644 --- a/deploy/helm/charts/templates/lvm-node-service.yaml +++ b/deploy/helm/charts/templates/lvm-node-service.yaml @@ -1,4 +1,4 @@ -{{- if .Values.lvmPlugin.metricsListenAddress }} +{{- if .Values.lvmPlugin.metricsPort }} apiVersion: v1 kind: Service metadata: @@ -9,8 +9,8 @@ spec: clusterIP: None ports: - name: metrics - port: {{ .Values.lvmPlugin.metricsListenAddress }} - targetPort: {{ .Values.lvmPlugin.metricsListenAddress }} + port: {{ .Values.lvmPlugin.metricsPort }} + targetPort: {{ .Values.lvmPlugin.metricsPort }} selector: {{- with .Values.lvmNode.podLabels }} {{ toYaml . }} diff --git a/deploy/helm/charts/templates/lvm-node.yaml b/deploy/helm/charts/templates/lvm-node.yaml index 171a2860..6d973c45 100644 --- a/deploy/helm/charts/templates/lvm-node.yaml +++ b/deploy/helm/charts/templates/lvm-node.yaml @@ -75,7 +75,7 @@ spec: - "--riops-per-gb=$(RIOPS_PER_GB)" - "--wiops-per-gb=$(WIOPS_PER_GB)" {{- end }} - {{- if .Values.lvmPlugin.metricsListenAddress }} + {{- if .Values.lvmPlugin.metricsPort }} - "--listen-address=$(METRICS_LISTEN_ADDRESS)" {{- end }} env: @@ -99,9 +99,9 @@ spec: - name: WIOPS_PER_GB value: {{ .Values.lvmPlugin.ioLimits.writeIopsPerGB }} {{- end }} - {{- if .Values.lvmPlugin.metricsListenAddress }} + {{- if .Values.lvmPlugin.metricsPort }} - name: METRICS_LISTEN_ADDRESS - value: :{{ .Values.lvmPlugin.metricsListenAddress }} + value: :{{ .Values.lvmPlugin.metricsPort }} {{- end }} volumeMounts: - name: plugin-dir diff --git a/deploy/helm/charts/values.yaml b/deploy/helm/charts/values.yaml index 5009cbb2..2dd4f4dc 100644 --- a/deploy/helm/charts/values.yaml +++ b/deploy/helm/charts/values.yaml @@ -132,10 +132,9 @@ lvmPlugin: containerRuntime: containerd readIopsPerGB: "" writeIopsPerGB: "" - # The TCP network address where the prometheus metrics endpoint will listen. - # The default is empty string, which means metrics endpoint is disabled. - # If not set, service will not be created to expose this endpoint to serviceMonitor and listen-address flag will not be set. - metricsListenAddress: 9500 + # Port number used for exposing lvm-metrics. + # If not set, service will not be created to expose metrics endpoint to serviceMonitor and listen-address flag will not be set. + metricsPort: 9500 role: openebs-lvm From d3c3194625d9c861e67136aeb21fafd1ecbcca4c Mon Sep 17 00:00:00 2001 From: Sahil Raja Date: Thu, 1 Jul 2021 10:32:16 +0530 Subject: [PATCH 10/12] Updated kind-action version Signed-off-by: Sahil Raja --- .github/workflows/chart-lint-test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/chart-lint-test.yml b/.github/workflows/chart-lint-test.yml index 309a3d09..2823aa99 100644 --- a/.github/workflows/chart-lint-test.yml +++ b/.github/workflows/chart-lint-test.yml @@ -45,7 +45,7 @@ jobs: run: ct lint --config ct.yaml - name: Create kind cluster - uses: helm/kind-action@v1.1.0 + uses: helm/kind-action@v1.2.0 if: steps.list-changed.outputs.changed == 'true' with: config: buildscripts/kind_config.yaml From c5f7e29ac887cde4ac4d505c3abdbc6f3fab93ad Mon Sep 17 00:00:00 2001 From: Sahil Raja Date: Thu, 1 Jul 2021 11:17:36 +0530 Subject: [PATCH 11/12] Updated comment Signed-off-by: Sahil Raja --- deploy/helm/charts/values.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/deploy/helm/charts/values.yaml b/deploy/helm/charts/values.yaml index 2dd4f4dc..de1bcb49 100644 --- a/deploy/helm/charts/values.yaml +++ b/deploy/helm/charts/values.yaml @@ -132,7 +132,7 @@ lvmPlugin: containerRuntime: containerd readIopsPerGB: "" writeIopsPerGB: "" - # Port number used for exposing lvm-metrics. + # The TCP port number used for exposing lvm-metrics. # If not set, service will not be created to expose metrics endpoint to serviceMonitor and listen-address flag will not be set. metricsPort: 9500 From 0cb1c7459b6d1572b2a9b09020bf23222e35ff38 Mon Sep 17 00:00:00 2001 From: Sahil Raja Date: Thu, 1 Jul 2021 11:22:20 +0530 Subject: [PATCH 12/12] Updated readme Signed-off-by: Sahil Raja --- deploy/helm/charts/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/deploy/helm/charts/README.md b/deploy/helm/charts/README.md index 4a7d7dc2..063e3772 100644 --- a/deploy/helm/charts/README.md +++ b/deploy/helm/charts/README.md @@ -79,7 +79,7 @@ The following table lists the configurable parameters of the OpenEBS LVM Localpv | `lvmPlugin.image.repository`| Image repository for openebs-lvm-plugin| `openebs/lvm-driver`| | `lvmPlugin.image.pullPolicy`| Image pull policy for openebs-lvm-plugin| `IfNotPresent`| | `lvmPlugin.image.tag`| Image tag for openebs-lvm-plugin| `0.6.0`| -| `lvmPlugin.metricsPort`| Port number used for exposing lvm-metrics | `9500`| +| `lvmPlugin.metricsPort`| The TCP port number used for exposing lvm-metrics | `9500`| | `lvmNode.driverRegistrar.image.registry`| Registry for csi-node-driver-registrar image| `k8s.gcr.io/`| | `lvmNode.driverRegistrar.image.repository`| Image repository for csi-node-driver-registrar| `sig-storage/csi-node-driver-registrar`| | `lvmNode.driverRegistrar.image.pullPolicy`| Image pull policy for csi-node-driver-registrar| `IfNotPresent`|