Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove is_production flag from Sites header/index #420

Open
braddf opened this issue Oct 16, 2023 · 0 comments
Open

Remove is_production flag from Sites header/index #420

braddf opened this issue Oct 16, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@braddf
Copy link
Contributor

braddf commented Oct 16, 2023

Describe the bug

Unnecessary code relating to NEXT_PUBLIC_IS_PRODUCTION env var on the Sites header link and the main view components in nowcasting-app/pages/index.tsx.

To Reproduce

Steps to reproduce the behavior:

  1. Go to Quartz UI
  2. Sites Header link is greyed out if NEXT_PUBLIC_IS_PRODUCTION is set to true

Expected behavior

The flag may be useful for anything that should look the same on Production and Staging for testing, but not on all Preview branches (differences in Dev/Prod API etc.) so we will keep it, but just don't need these particular disabled elements tied to it anymore.

@braddf braddf added the bug Something isn't working label Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant