Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e2e tests #155

Closed
wants to merge 16 commits into from
Closed

e2e tests #155

wants to merge 16 commits into from

Conversation

dlinah
Copy link
Contributor

@dlinah dlinah commented Jul 10, 2022 •
edited
Loading

Pull Request

main pr for testing stories

main story:
Fixes #28

sub stories:
Fixes #145, Fixes #146, Fixes #147, Fixes #148

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@vercel
Copy link

vercel bot commented Jul 10, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nowcasting-app ✅ Ready (Inspect) Visit Preview Aug 25, 2022 at 2:00PM (UTC)
nowcasting-website ✅ Ready (Inspect) Visit Preview Aug 25, 2022 at 2:00PM (UTC)

@dlinah dlinah marked this pull request as draft July 10, 2022 10:04
@dlinah dlinah changed the title complete dummy api data tests Jul 11, 2022
@dlinah dlinah changed the title tests e2e tests Jul 11, 2022
@dlinah dlinah changed the base branch from main to development July 11, 2022 21:53
@dlinah dlinah force-pushed the cypress-test branch 2 times, most recently from a310195 to c5572b6 Compare July 11, 2022 22:40
@dctanner
Copy link
Contributor

dctanner commented Aug 4, 2022

Sorry about the conflicts, hoepfully you can sort them. Please get @dctanner to review this soon ish, so we can avoid further branch conflcts

I'm on holiday for another 2.5w so might be best to go ahead without me.

@peterdudfield
Copy link
Contributor

Sorry about the conflicts, hoepfully you can sort them. Please get @dctanner to review this soon ish, so we can avoid further branch conflcts

I'm on holiday for another 2.5w so might be best to go ahead without me.

@dlinah you ok to sort the conflicts and then we can merge. @dctanner can review this after the holiday. Sound ok?

@dctanner
Copy link
Contributor

Looking good Linah. I've been able to do a brief review, but I've asked @Alaatohamy to do a more in depth review because she has more context to review the actual code.

@dlinah
Copy link
Contributor Author

dlinah commented Aug 25, 2022

@Alaatohamy lmk if you wanna do a pair review

@Alaatohamy
Copy link
Contributor

@Alaatohamy lmk if you wanna do a pair review

sure do you want to pair now ?

@dlinah dlinah mentioned this pull request Aug 28, 2022
Closed
@braddf braddf closed this Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alaatohamy Alaatohamy Awaiting requested review from Alaatohamy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@dlinah @peterdudfield @dctanner @Alaatohamy @braddf