Skip to content
This repository has been archived by the owner on Sep 28, 2023. It is now read-only.

Issue/63 skip test #68

Merged
merged 28 commits into from
Nov 22, 2021
Merged

Issue/63 skip test #68

merged 28 commits into from
Nov 22, 2021

Conversation

peterdudfield
Copy link
Collaborator

@peterdudfield peterdudfield commented Nov 22, 2021 •
edited
Loading

Pull Request

Description

  • Stopped using x-dist
  • skipping test due to issue 63
  • skipped test due to issue 66

Fixes #63

How Has This Been Tested?

unittests

  • No
  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

peterdudfield and others added 28 commits November 22, 2021 13:25
@peterdudfield
skip tests
bde8d95
@peterdudfield
skip a few more
ebb2069
@peterdudfield
comment out tests
b9248c4
@peterdudfield
comment out tests
72f2675
@peterdudfield
comment out mroe tests
b0edc08
@peterdudfield
put tests back in
b2600e9
@peterdudfield
only have one pytest configruation
04df9c7
@peterdudfield
fix
f640c9e
@peterdudfield
remove one test
59ca41b
@peterdudfield
done use pytest-xdist
7acb4f9
@peterdudfield
lower case
890ac3e
@peterdudfield
try again
552cf4f
@peterdudfield
add comment on seperate line
1d57119
@peterdudfield
rename "pytest_numcpus"
9e29354
@peterdudfield
git push
3f2fce9
@peterdudfield
change to string
22c8ede
@peterdudfield
make gitflow be steps
d4a51c5
@peterdudfield
tidy
35d906e
@peterdudfield
add tests back in
50ab98d
@peterdudfield
remove test skipping
5c99731
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
eea5880 
for more information, see https://pre-commit.ci
@peterdudfield
tidy up read for PR
644b95a
@peterdudfield
Merge branch 'issue/63-skip-test' of github.com:openclimatefix/nowcas…
1a19df4 
…ting_dataloader into issue/63-skip-test

# Conflicts:
#	tests/test_position_encoding.py
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
b4fc675 
for more information, see https://pre-commit.ci
@peterdudfield
tidy
0b6033b
@peterdudfield
Merge branch 'issue/63-skip-test' of github.com:openclimatefix/nowcas…
cf7f787 
…ting_dataloader into issue/63-skip-test

# Conflicts:
#	tests/test_batch.py
@peterdudfield
skipping tests due to issue #66
a7b5374
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
707d875 
for more information, see https://pre-commit.ci
jacobbieker
jacobbieker approved these changes Nov 22, 2021
View reviewed changes
Copy link
Member

@jacobbieker jacobbieker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for fixing these

@peterdudfield peterdudfield self-assigned this Nov 22, 2021
@peterdudfield peterdudfield merged commit fa827b3 into main Nov 22, 2021
@peterdudfield peterdudfield deleted the issue/63-skip-test branch December 1, 2021 22:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jacobbieker jacobbieker jacobbieker approved these changes

Assignees

@peterdudfield peterdudfield

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Subselect doesn't work without the metadata in Batch
2 participants
@peterdudfield @jacobbieker