Fix height of container for creating new annotations #638
Conversation
|
It now works as expected. Thx for the fix! |
There was a problem hiding this comment.
The culprit here was 61478c9.
However, I see no difference between what this PR does, and not applying this class at all, in which case we could get rid of it, too, since it isn't used anywhere else.
However again I'm not sure the result is what we want: The problem is (still/again) that when you have many labels in one category, the white container expands to accommodate them, potentially pushing the checkboxes outside the visible area and making you scroll, instead of having to scroll within the white container itself to reach all the categories.
@dagraf can you clarify what the requirements are?
|
@JulianKniephoff The requirement as I see it would be: "A user can see the options to stop the video when this user does freshly load a video." |
|
I don't really have anything specific in mind. But yeah, the requirement as you stated it is not met by this change, when you have a sufficient amount of labels in a category, right? Am I doing something wrong? 🤔 |
|
Right. But as you do not have a specific improvement in mind which can meet the stated requirement and as I said that I can live with the current solution: We implement this solution and close this ticket. |
|
Fair. :) I would still say that we should just get rid of |
|
@JulianKniephoff Agreed, I removed the container and as you said it doesn't seem to change anything else. |
This PR should fix #630 .
For some reason the default height for the container containing the labels was set to
100vh. I set this toautoso that it won't use the whole screen height.I also changed the value for
overflow-ytoautoso that the scrollbar for labels is only visible, when neccessary.