Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editing categories: Window after clicking on the arrow gets hidden when there are categories with only few labels #552

Open
dagraf opened this issue Nov 23, 2021 · 6 comments

Comments

@dagraf
Copy link
Collaborator

dagraf commented Nov 23, 2021

See screenshot

Screenshot (33)

@dagraf dagraf changed the title Editing categories: Window after clicking on the arrow gets hidden when there are categories with only with labels Editing categories: Window after clicking on the arrow gets hidden when there are categories with only few labels Nov 23, 2021
@dagraf
Copy link
Collaborator Author

dagraf commented Dec 9, 2021

Note: This is not an urgent bug. Mainly because the user can manually enlarge the "Create new annotations" window. But anyhow it should be fixed some time...

@JulianKniephoff
Copy link
Member

The sad truth is also that this isn't an easy thing to fix. You would think that it is, but ti's complicated by the convoluted structure of the "structured annotation creation component," and even the naive and hacky ways of working around that are squashed by us using an ancient version of the "UI framework" (talking about Bootstrap) we are using. 😞

@dagraf
Copy link
Collaborator Author

dagraf commented Jan 3, 2022

Truly sad but not that important. Here some ideas for workaround solutions to gain more space for the box containing the categories with its labels:
a) The default hight for free text annotations could be made a bit smaller.
b) In the layout preset "Standard" the window "Create new annotations" could be made higher than the window "Annotation list". For example: "Create new annotations" = 3/5 of max. hight; "Annotation list" = 2/5 of max. hight

What do you think of these possible workarounds?

@ChristianOellers
Copy link
Contributor

Maybe a CSS cheat can help with position:fixed; or other more modern CSS approaches (?):

CSS cheat

Challenges would then be:

  • Does it work in all browsers?
  • Position needs to be calculated from the origin element (hardcoded for screenshot)
  • On resizing the window, it should be either repositioned -or- closed

@JulianKniephoff
Copy link
Member

I don't want to sound mean or anything, but I would really hesitate to add a lot of complexity to fix this. If there is a simple CSS one-liner, sure, but I don't think there is. Adding JavaScript code to dynamically reposition this window, etc. when this functionality already exists in newer versions of Bootstrap seems crazy to me. We should update our dependencies, not haphazardly duplicate their functionality. 🤔 It's exactly decisions like this that brought about the current state of the code base; choosing quick fixes over long term maintainability.

As for the workarounds suggested by David (sorry, somehow I'm only seeing this now): I have nothing against that. It's easy, and it's also not like I put a lot of thought into that Standard layout. x)

@dagraf
Copy link
Collaborator Author

dagraf commented Feb 9, 2023

Bug still exists in merged version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants