You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Level Up Advanced 5e makes a spell's area one of its parameters. When A5e spells were imported into Open5e, this doesn't appear to have made it to the API. I checked both Open5e itself, the Open5e API, and the raw data in Github and it's missing from all of them.
There are two potential ways to fix this. One is to add an "area" parameter to the spell JSON structure and fill it in. The other would be to add the area to the text description for each one as part of the ETL from whatever source we draw it in from.
I don't think other spell sources have area as a field so that might be the better answer. I also don't know how critical it is to have it as a separate parameter from a computational standpoint, particularly if A5e is the only source that has it.
I whipped up a JSON file that has the areas in a text description format. I think this could be added to the beginning of each A5e spell description without looking too weird and without having to change the JSON format for all spells.
If we agree that adding the area description to the beginning of each A5e spell that has an area is the way to go, I can add this to their spells and do a merge request.
If we decide its better to create new fields in the JSON, here's a JSON file that has the more granular area descriptions. a5e_spell_areas_2nd.json
I think A5e spells are also missing components...
The text was updated successfully, but these errors were encountered:
From Slyflourish:
Level Up Advanced 5e makes a spell's area one of its parameters. When A5e spells were imported into Open5e, this doesn't appear to have made it to the API. I checked both Open5e itself, the Open5e API, and the raw data in Github and it's missing from all of them.
There are two potential ways to fix this. One is to add an "area" parameter to the spell JSON structure and fill it in. The other would be to add the area to the text description for each one as part of the ETL from whatever source we draw it in from.
I don't think other spell sources have area as a field so that might be the better answer. I also don't know how critical it is to have it as a separate parameter from a computational standpoint, particularly if A5e is the only source that has it.
I whipped up a JSON file that has the areas in a text description format. I think this could be added to the beginning of each A5e spell description without looking too weird and without having to change the JSON format for all spells.
a5e_spell_areas.json
If we agree that adding the area description to the beginning of each A5e spell that has an area is the way to go, I can add this to their spells and do a merge request.
If we decide its better to create new fields in the JSON, here's a JSON file that has the more granular area descriptions.
a5e_spell_areas_2nd.json
I think A5e spells are also missing components...
The text was updated successfully, but these errors were encountered: