Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Way to compare if a v1 data item has not been converted to v2 #442

Closed
augustjohnson opened this issue Apr 12, 2024 · 1 comment · Fixed by #594
Closed

Way to compare if a v1 data item has not been converted to v2 #442

augustjohnson opened this issue Apr 12, 2024 · 1 comment · Fixed by #594
Assignees
@augustjohnson

Comments

@augustjohnson
Copy link
Collaborator

This gets complicated for items, because they don't align 1 to 1, maybe just skip those, and assume it's ok?

Most of the other data types do align 1 to 1, so straight up comparing counts could be ok.
@augustjohnson
Copy link
Collaborator Author

Also, with name standardization, these can mostly be derived from a simple set of rules.

@augustjohnson augustjohnson self-assigned this Oct 19, 2024
@augustjohnson augustjohnson linked a pull request Oct 23, 2024 that will close this issue
442 way to compare if a v1 data item has not been converted to v2 #594
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@augustjohnson augustjohnson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

442 way to compare if a v1 data item has not been converted to v2 open5e/open5e-api
1 participant
@augustjohnson