Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move pyx files to ./engines or ./ext? #8

Open
hrahmanin opened this issue Oct 3, 2023 · 2 comments
Open

move pyx files to ./engines or ./ext? #8

hrahmanin opened this issue Oct 3, 2023 · 2 comments

Comments

@hrahmanin
Copy link
Collaborator

hrahmanin commented Oct 3, 2023 •
edited
Loading

'looplib/simlef_onesided.pyx' is not included in setup.py, leading to an error when importing simlef_onesided at the start of this notebook.

todo: just add it to ext_modules
@gfudenberg
Copy link
Member

looking at the directory structure, I wonder if all pyx files might be better moved to a folder ./engines ? and then then ./engines/*.pyx could be cythonized? cc @golobor

@hrahmanin hrahmanin changed the title simlef_onesided import simlef_onesided import error in sample_simulation_onesided.ipynb Oct 3, 2023
@gfudenberg gfudenberg changed the title simlef_onesided import error in sample_simulation_onesided.ipynb move pyx files to ./engines or ./ext? Oct 3, 2023
@gfudenberg
Copy link
Member

resolved original issue in 0ea23c8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gfudenberg @hrahmanin