Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement score_answer() for HanoiDataset (Tower of Hanoi) #37

Closed
andreaskoepf opened this issue Jan 31, 2025 · 1 comment · Fixed by #50
Closed

Implement score_answer() for HanoiDataset (Tower of Hanoi) #37

andreaskoepf opened this issue Jan 31, 2025 · 1 comment · Fixed by #50

Comments

@andreaskoepf
Copy link
Contributor

In the first version of the Tower of Hanoi task dataset the HanoiDataset class generates a list of instructions as answer. This list cannot be correctly processed by the default implementation of score_answer() in the ProceduralDataset base class. Beside the optimal solution (minimum number of moves) a non-optimal solution (leading to correct end configuration) should also get a non-zero score.

Override the score_answer() method in HannoiDataset and compute a score based on correctness of the end-configuration and number of steps (e.g. compared to optimal solution).

@andreaskoepf andreaskoepf linked a pull request Jan 31, 2025 that will close this issue
@andreaskoepf andreaskoepf removed a link to a pull request Jan 31, 2025
@andreaskoepf
Copy link
Contributor Author

(@joenorton can probably work on this tomorrow)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant