Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[editorial] Invalid / retired link into Docker spec #1865

Closed
Tracked by #6196
chalin opened this issue Feb 4, 2025 · 1 comment · Fixed by #1881
Closed
Tracked by #6196

[editorial] Invalid / retired link into Docker spec #1865

chalin opened this issue Feb 4, 2025 · 1 comment · Fixed by #1881
Labels
area:container area:oci bug Something isn't working

Comments

@chalin
Copy link
Contributor

chalin commented Feb 4, 2025

The reference https://docs.docker.com/registry/spec/manifest-v2-2/#example-image-manifest is to a "retired" concept:

$ curl -sI https://docs.docker.com/registry/spec/manifest-v2-2/#example-image-manifest | grep -Ee '^(HTTP|loc)' 
HTTP/2 301 
location: /retired/

Here is where it occurs in the docs:

content-modules/semantic-conventions/docs/attributes-registry/oci.md:
  14  **[1] `oci.manifest.digest`:** Follows [OCI Image Manifest Specification](https://github.com/opencontainers/image-spec/blob/main/manifest.md), and specifically the [Digest property](https://github.com/opencontainers/image-spec/blob/main/descriptor.md#digests).
  15: An example can be found in [Example Image Manifest](https://docs.docker.com/registry/spec/manifest-v2-2/#example-image-manifest).
  16  

content-modules/semantic-conventions/docs/resource/container.md:
  38  **[3] `oci.manifest.digest`:** Follows [OCI Image Manifest Specification](https://github.com/opencontainers/image-spec/blob/main/manifest.md), and specifically the [Digest property](https://github.com/opencontainers/image-spec/blob/main/descriptor.md#digests).
  39: An example can be found in [Example Image Manifest](https://docs.docker.com/registry/spec/manifest-v2-2/#example-image-manifest).
  40  

content-modules/semantic-conventions/model/oci/registry.yaml:
  20            An example can be found in
  21:           [Example Image Manifest](https://docs.docker.com/registry/spec/manifest-v2-2/#example-image-manifest).
  22          examples: [ 'sha256:e4ca62c0d62f3e886e684806dfe9d4e0cda60d54986898173c1083856cfda0f4' ]

static/refcache.json:
  1105    },
  1106:   "https://docs.docker.com/registry/spec/manifest-v2-2/#example-image-manifest": {
  1107      "StatusCode": 206,

What should this link be replaced by? Ideally a link that has HTTP status 200, not 301.

This issue is reported in the scope of:

@trask
Copy link
Member

trask commented Feb 4, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:container area:oci bug Something isn't working
Projects
Development

Successfully merging a pull request may close this issue.

3 participants