Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop unneeded requirements from tornado test-requirements #3173

Open
xrmx opened this issue Jan 7, 2025 · 0 comments
Open

Drop unneeded requirements from tornado test-requirements #3173

xrmx opened this issue Jan 7, 2025 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@xrmx
Copy link
Contributor

xrmx commented Jan 7, 2025

Describe your environment

OS: (e.g, Ubuntu)
Python version: (e.g., Python 3.8.10)
Package version: (e.g., 0.46.0)

What happened?

Double check that the following libraries are required in tornado test-requirements:

blinker==1.7.0
Flask==3.0.2
itsdangerous==2.1.2
Jinja2==3.1.4
MarkupSafe==2.1.2
Werkzeug==3.0.6

Looks like they have been copied from a flask test-requirements file.

Steps to Reproduce

Look at tornado instrumentation test-requirements.txt

Expected Result

No flask related library present

Actual Result

Flask related libraries are there

Additional context

No response

Would you like to implement a fix?

No
@xrmx xrmx added bug Something isn't working good first issue Good for newcomers labels Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@xrmx