click: ignore click based servers #3174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xrmx
commented
Jan 7, 2025
...tion/opentelemetry-instrumentation-click/src/opentelemetry/instrumentation/click/__init__.py
Show resolved
Hide resolved
xrmx
commented
Jan 7, 2025
instrumentation/opentelemetry-instrumentation-click/tests/test_click.py
Outdated
Show resolved
Hide resolved
We don't want to create a root span for long running processes like servers otherwise all requests would have the same trace id which is unfortunate.
xrmx
force-pushed
the
disable-click-for-webservers
branch
from
0c1fbde to
770a6e3
Compare
...tion/opentelemetry-instrumentation-click/src/opentelemetry/instrumentation/click/__init__.py
Outdated
Show resolved
Hide resolved
...tion/opentelemetry-instrumentation-click/src/opentelemetry/instrumentation/click/__init__.py
Show resolved
Hide resolved
codefromthecrypt
approved these changes
Jan 7, 2025
…lemetry/instrumentation/click/__init__.py Co-authored-by: Tammy Baylis <[email protected]>
emdneto
approved these changes
Jan 8, 2025
Kludex
reviewed
Jan 10, 2025
Comment on lines
+172
to
+177
| @click.command("uvicorn") | ||
| def command_uvicorn(): | ||
| pass | ||
|
|
||
| runner = CliRunner() | ||
| result = runner.invoke(command_uvicorn) |
There was a problem hiding this comment.
I think we could just call from uvicorn.main import main as uvicorn_command and use it instead of mocking it. Flask is not being mocked.
Please do not ask me to create an issue. I'm good. 🙏
There was a problem hiding this comment.
If you look at the code flask is recognized by checking a parameter type since the command name run is pretty generic. uvicorn name is pretty unique..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We don't want to create a root span for long running processes like development web servers otherwise all requests would have the same trace id which is unfortunate.
Fixes #3171
Fixes #3172
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.