Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sdk-trace-base] [sdk-trace-node] remove propagator auto-configuration from package #4672

Open
3 tasks
pichlermarc opened this issue May 3, 2024 · 0 comments · May be fixed by #5355
Open
3 tasks

[sdk-trace-base] [sdk-trace-node] remove propagator auto-configuration from package #4672

pichlermarc opened this issue May 3, 2024 · 0 comments · May be fixed by #5355
Labels
never-stale pkg:sdk-trace-base pkg:sdk-trace-node target:next-major-release This PR targets the next major release (`next` branch) type:feature-tracking A feature with sub-issues that need to be addressed
Milestone
Future Major Vers...

Comments

@pichlermarc
Copy link
Member

Description

It is currently confusing which packages implement auto-configure and to which extent. We've previously auto-instantiated propagators from sdk-trace-base and sdk-trace-node.

In SDK 2.0 we should move any auto-configuration functionality to @opentelemetry/sdk-node, any only apply direct-code configuration in sdk-trace-base and sdk-trace-node. Therefore we should remove that auto-configuration of propagators from sdk-trace-base and sdk-trace-node and implement it in @opentelemetry/sdk-node instead.

This issue is considered done when

  • auto-instantiation of propagators based on env vars is removed from sdk-trace-base
  • auto-instantiation of propagators based on env vars is removed from sdk-trace-node
  • auto-instantiation of propagators based on env vars is implemented in sdk-node
@pichlermarc pichlermarc added pkg:sdk-trace-base pkg:sdk-trace-node type:feature-tracking A feature with sub-issues that need to be addressed target:next-major-release This PR targets the next major release (`next` branch) labels May 3, 2024
@pichlermarc pichlermarc added this to the OpenTelemetry SDK 2.0 milestone May 3, 2024
@pichlermarc pichlermarc changed the title [sdk-trace-base] [sdk-trace-node] remove propagator env var configuration from package [sdk-trace-base] [sdk-trace-node] remove propagator auto-configuration from package May 3, 2024
@pichlermarc pichlermarc mentioned this issue May 3, 2024
Merged
4 tasks
@pichlermarc pichlermarc mentioned this issue Dec 20, 2024
Open
@pichlermarc pichlermarc linked a pull request Jan 21, 2025 that will close this issue
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
never-stale pkg:sdk-trace-base pkg:sdk-trace-node target:next-major-release This PR targets the next major release (`next` branch) type:feature-tracking A feature with sub-issues that need to be addressed
Projects
None yet
Milestone
Future Major Versions
2 participants
@pichlermarc @JamieDanielson