Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move controller out of internal package #272

Open
mchataigner opened this issue Dec 9, 2024 · 0 comments
Open

Move controller out of internal package #272

mchataigner opened this issue Dec 9, 2024 · 0 comments

Comments

@mchataigner
Copy link
Contributor

Hello, I saw that Controller has been added recently to abstract the agent startup.
I like the idea, however the fact that it lies within an internal package makes it impossible to extend from another app.
I would suggest moving internal/controller and internal/helpers to non-internal package to allow hacking/tweaking with opentelemetry-ebpf-profiler.
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant