[bug] OpenTelemetry.Instrumentation.EntityFrameworkCore v1.0.0-beta.10 - Devart.Data.Oracle is missing db.statement tag and has wrong db.system value #2462
Labels
bug
Something isn't working
comp:instrumentation.entityframeworkcore
Things related to OpenTelemetry.Instrumentation.EntityFrameworkCore
Comments
github-actions
bot
added
the
comp:instrumentation.entityframeworkcore
|
@vladajankovic, would you like to contribute fixes (PRs)? I think, that it will be better to have 2 separate, one for db.system, the second for the db.statement. Please remember to include CHANGELOG entries with brief descriptions. |
|
@Kielek Sure thing 😄 I will make 2 PRs tomorrow. |
This was referenced Jan 15, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Component
OpenTelemetry.Instrumentation.EntityFrameworkCore
Package Version
Runtime Version
net8.0
Description
Package versions:
v10.3.104v10.3.105.8v1.0.0-beta.10The
providerNamefor Devart.Data.Oracle is"Devart.Data.Oracle.Entity.EFCore", and not"Devart.Data.Oracle.EFCore", which misses the correct switch case and executes the default casedb.system="other_sql"Source CodeAlso, an exception is thrown on this line when Fetchers are used in a specific case when the command is CommandType.Text, and the db.statement is not set.
Steps to Reproduce
Use these package versions:
v10.3.104v10.3.105.8v1.0.0-beta.10Expected Result
Activity class to have tags
db.system="oracle"anddb.statementthat contains the sql statementActual Result
Activity class has tag
db.system="other_sql"and thedb.statementtag is missingAdditional Context
No response
The text was updated successfully, but these errors were encountered: