[logzioexporter] Remove dependency on jaeger dbmodel #36972
Merged
+459
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
yurishkuro
reviewed
Dec 27, 2024
yurishkuro
reviewed
Dec 27, 2024
yurishkuro
pushed a commit
to jaegertracing/jaeger
that referenced
this pull request
Dec 27, 2024
## Which problem is this PR solving? - Resolves #6410 - Prerequisite: open-telemetry/opentelemetry-collector-contrib#36972 ## Description of the changes - move plugin/storage/es/spanstore/dbmodel to plugin/storage/es/spanstore/internal/dbmodel ## How was this change tested? - ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [ ] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` --------- Signed-off-by: zzzk1 <[email protected]>
yurishkuro
reviewed
Dec 27, 2024
yurishkuro
reviewed
Dec 28, 2024
yurishkuro
reviewed
Dec 28, 2024
yurishkuro
reviewed
Dec 28, 2024
|
@fatsheep9146 @yurishkuro @yotamloe Improved, please take a look 😊 |
zzzk1
force-pushed
the
remove-dbmodel
branch
from
344199d to
c575410
Compare
yurishkuro
reviewed
Dec 29, 2024
zzzk1
commented
Dec 30, 2024
yurishkuro
reviewed
Dec 30, 2024
yurishkuro
reviewed
Jan 1, 2025
yurishkuro
approved these changes
Jan 3, 2025
yurishkuro
changed the title
yurishkuro
changed the title
yotamloe
approved these changes
Jan 4, 2025
atoulme
added
the
ready to merge
Manik2708
pushed a commit
to Manik2708/jaeger
that referenced
this pull request
Jan 5, 2025
…g#6428) - Resolves jaegertracing#6410 - Prerequisite: open-telemetry/opentelemetry-collector-contrib#36972 - move plugin/storage/es/spanstore/dbmodel to plugin/storage/es/spanstore/internal/dbmodel - - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [ ] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` --------- Signed-off-by: zzzk1 <[email protected]>
andrzej-stencel
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Copy the Jaeger plugin/storage/es/spanstore/dbmodel for logzioexporter, and remove the dependency. The dbmodel package in Jaeger will be internal from v1.65 (jaegertracing/jaeger#6428).
Link to tracking issue
Fixes #36970
Testing
Covered by existing