Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show pdf file on website #129

Closed
wants to merge 2 commits into from

Conversation

a0m0rajab
Copy link
Contributor

Description

This PR changes the PDF file location to assets to use it in the browser and show it, previously the pdf were showing on the local machine but not working on the browser.

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Fixes #97

Mobile & Desktop Screenshots/Recordings

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📜 README.md
  • 📓 docs.opensauced.pizza
  • 🍕 dev.to/opensauced
  • 📕 storybook
  • 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

@netlify
Copy link

netlify bot commented Aug 6, 2023

👷 Deploy request for docs-open pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 34b3769

@a0m0rajab
Copy link
Contributor Author

I was expecting it to work... can we check if the file is created in the assets folder?

@bdougie
Copy link
Member

bdougie commented Aug 11, 2023

I was expecting it to work... can we check if the file is created in the assets folder?

You can workflows manually on your fork to confirm. https://www.youtube.com/watch?v=zOswqcXpQ54

@CBID2 CBID2 added 📝 documentation chore label to mark dependency and documentation updates labels Sep 25, 2023
@BekahHW
Copy link
Member

BekahHW commented Sep 27, 2023

@a0m0rajab have you been able to test this?

@a0m0rajab
Copy link
Contributor Author

@BekahHW yes, it worked locally!
sorry for the late reply.

@CBID2
Copy link
Contributor

CBID2 commented Oct 25, 2023

@BekahHW yes, it worked locally! sorry for the late reply.

There's some conflicts that need to be solved on your branch @a0m0rajab

@a0m0rajab
Copy link
Contributor Author

@CBID2 resolved.

@CBID2
Copy link
Contributor

CBID2 commented Nov 2, 2023

@bdougie, this needs review

Copy link
Contributor

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! :)

@CBID2
Copy link
Contributor

CBID2 commented Nov 16, 2023

@a0m0rajab, we merged some new PRs, so can you solve the merge conflicts on your branch?

@CBID2
Copy link
Contributor

CBID2 commented Dec 11, 2023

Hey @a0m0rajab. Are you still working on this?

@BekahHW
Copy link
Member

BekahHW commented Jan 11, 2024

@a0m0rajab I'm still not able to get this working locally.

image

@a0m0rajab
Copy link
Contributor Author

@BekahHW How did you run this locally? for me, I just went through the docs and it worked without any further modification.

@BekahHW
Copy link
Member

BekahHW commented Jan 15, 2024

@a0m0rajab I ran npm ci and npm start.

@BekahHW BekahHW marked this pull request as draft January 18, 2024 18:19
@BekahHW
Copy link
Member

BekahHW commented Apr 20, 2024

Since we weren't able to get this consistently working, I removed it from the footer. I'm going to close this issue for now because we're about to merge in a PR that uses an updated version of docusaurus, so it would probably be easier to start over. But feel free to reopen.

@BekahHW BekahHW closed this Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore label to mark dependency and documentation updates 📝 documentation merge-conflicts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: download book link goes to 404
5 participants