-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: show pdf file on website #129
Conversation
👷 Deploy request for docs-open pending review.Visit the deploys page to approve it
|
I was expecting it to work... can we check if the file is created in the assets folder? |
You can workflows manually on your fork to confirm. https://www.youtube.com/watch?v=zOswqcXpQ54 |
@a0m0rajab have you been able to test this? |
@BekahHW yes, it worked locally! |
There's some conflicts that need to be solved on your branch @a0m0rajab |
@CBID2 resolved. |
@bdougie, this needs review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! :)
@a0m0rajab, we merged some new PRs, so can you solve the merge conflicts on your branch? |
Hey @a0m0rajab. Are you still working on this? |
@a0m0rajab I'm still not able to get this working locally. |
@BekahHW How did you run this locally? for me, I just went through the docs and it worked without any further modification. |
@a0m0rajab I ran |
Since we weren't able to get this consistently working, I removed it from the footer. I'm going to close this issue for now because we're about to merge in a PR that uses an updated version of docusaurus, so it would probably be easier to start over. But feel free to reopen. |
Description
This PR changes the PDF file location to assets to use it in the browser and show it, previously the pdf were showing on the local machine but not working on the browser.
What type of PR is this? (check all applicable)
Related Tickets & Documents
Fixes #97
Mobile & Desktop Screenshots/Recordings
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?