Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

/impressum and /datenschutz are 404 on test website #408

Open
FlorianK13 opened this issue Jan 17, 2025 · 3 comments
Open

/impressum and /datenschutz are 404 on test website #408

FlorianK13 opened this issue Jan 17, 2025 · 3 comments
Assignees
@FlorianK13
Labels
bug Something isn't working

Comments

@FlorianK13
Copy link
Member

We need to inspect this. Might be a bug, might also be a wrong config with github pages. Deploying the site locally I cannot reproduce this error.
@FlorianK13 FlorianK13 added the bug Something isn't working label Jan 17, 2025
@khdlr
Copy link
Member

khdlr commented Jan 17, 2025

I believe this is Nginx-config specific, as these routes are actually handled by the React router. In our deployed website, we also serve the main HTML for these pages and the JS code then correctly displays impressum/datenschutz. Not sure if this is reproducible within GH pages.

@FlorianK13
Copy link
Member Author

I guess we will find out with our next release :)

@FlorianK13
Copy link
Member Author

We should change the workflow to a true "deploy from workflow" instead of our "deploy from branch", that might help.

@FlorianK13 FlorianK13 self-assigned this Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FlorianK13 FlorianK13

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@khdlr @FlorianK13