Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

services: smoother info (fixes #5006) #5016

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

services: smoother info (fixes #5006) #5016

wants to merge 6 commits into from

Conversation

Avinash-Codes
Copy link
Member

fixes #5006

image

@Avinash-Codes Avinash-Codes linked an issue Jan 13, 2025 that may be closed by this pull request
empty services place holder #5006
Open
Okuro3499
Okuro3499 requested changes Jan 14, 2025
View reviewed changes
Copy link
Collaborator

@Okuro3499 Okuro3499 left a comment •
edited by Avinash-Codes
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the services page shows description and links show two placeholders similar to planet as we could have either of then not available. check planet screenshot on the issue description
#5006 (comment)

@Avinash-Codes
Copy link
Member Author

the services page shows description and links show two placeholders similar to planet as we could have either of then not available. check planet screenshot on the issue description #5006 (comment)

fixed

Okuro3499
Okuro3499 requested changes Jan 15, 2025
View reviewed changes
app/src/main/res/layout/placeholder_services.xml Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not necessary to add a new layout file. Just add textviews for each in the fragment_services and toggle visibility depending on the response you get

app/src/main/res/drawable/service.png Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cleanup this drawable too

Okuro3499
Okuro3499 requested changes Jan 16, 2025
View reviewed changes
Copy link
Collaborator

@Okuro3499 Okuro3499 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Avinash-Codes I added a description on planet but the placeholders are still what I see on myplanet
Screenshot_20250116_140029
Screenshot 2025-01-16 at 14 02 03

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Okuro3499 Okuro3499 Okuro3499 requested changes

@pavi38 pavi38 pavi38 approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
changes requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

empty services place holder
3 participants
@Avinash-Codes @Okuro3499 @pavi38