Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Brotli Compression #176

Open
refcell opened this issue Feb 5, 2025 · 3 comments · May be fixed by #243
Open

[Feature] Brotli Compression #176

refcell opened this issue Feb 5, 2025 · 3 comments · May be fixed by #243
Assignees
@SkandaBhat
Labels
A-protocol Area: protocol crate C-debt Category: technical debt or removable C-feat Category: new feature or request C-perf Category: improvements to performance D-good-first-issue Desc: issues that are easy to pick up for new contributors

Comments

@refcell
Copy link
Contributor

refcell commented Feb 5, 2025

Component

protocol

Describe the feature you would like

Perform brotli compression using the brotli::CompressorWriter and a buffer instead of storing both the raw and compressed data and re-compressing the entire raw data as currently done.

Additional context

See: #14.

Notice, tests are failing here because of a bug with the implementation.
@refcell refcell added C-feat Category: new feature or request D-needs-triage Desc: this issue needs to be labelled A-protocol Area: protocol crate C-debt Category: technical debt or removable D-good-first-issue Desc: issues that are easy to pick up for new contributors C-perf Category: improvements to performance and removed D-needs-triage Desc: this issue needs to be labelled labels Feb 5, 2025
@refcell refcell mentioned this issue Feb 5, 2025
Closed
@SkandaBhat
Copy link
Contributor

I can try looking at this @refcell

@refcell
Copy link
Contributor Author

refcell commented Feb 10, 2025

I can try looking at this @refcell

That'd be great!

@refcell
Copy link
Contributor Author

refcell commented Feb 10, 2025

I've assigned you for now, let me know if you don't have time otherwise :)

@refcell refcell moved this from Backlog to Out of Scope in Project Tracking Feb 11, 2025
@SkandaBhat SkandaBhat linked a pull request Feb 12, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SkandaBhat SkandaBhat

Labels
A-protocol Area: protocol crate C-debt Category: technical debt or removable C-feat Category: new feature or request C-perf Category: improvements to performance D-good-first-issue Desc: issues that are easy to pick up for new contributors
Projects
Project Tracking
Status: Out of Scope
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(protocol): implement brotli buffer for compressor SkandaBhat/maili
2 participants
@SkandaBhat @refcell