Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check-in: return test helpers info and deprecate /api/v1/test-helpers #2392

Open
2 of 5 tasks
Tracked by #2362
bassosimone opened this issue Dec 16, 2022 · 1 comment
Open
2 of 5 tasks
Tracked by #2362
Assignees
Labels
cleanup There's need to cleanup stuff a bit enhancement New feature request or improvement to existing functionality funder/drl2022-2024 ooni/probe-engine priority/low Nice to have technical task technical tasks e.g. deployment

Comments

@bassosimone
Copy link
Contributor

bassosimone commented Dec 16, 2022

This issue is about improving performance by obtaining test helpers info via check-in.

Here's what we need to do more in detail:

  • backend: modify /api/v1/check-in to return test helpers info
  • sysadmin: deploy new backend
  • probe: use /api/v1/check-in to obtain test helpers info
  • probe: drop code to call /api/v1/test-helpers
  • backend: deprecate /api/v1/test-helpers

We discussed this topic internally with @hellais and @FedericoCeratto a few days ago.

More specifically, we will add the following key to the check-in API response:

{
  "conf": {
    "test_helpers": {
      /* Information currently returned by /api/v1/test-helpers */
    }
  }
}
@bassosimone bassosimone self-assigned this Dec 16, 2022
@bassosimone bassosimone added enhancement New feature request or improvement to existing functionality cleanup There's need to cleanup stuff a bit funder/drl2022-2024 priority/high Important issue that needs attention soon technical task technical tasks e.g. deployment ooni/probe-engine labels Dec 16, 2022
@hellais hellais added this to Roadmap Jan 7, 2025
@hellais hellais added priority/medium Normal priority issue and removed priority/high Important issue that needs attention soon labels Jan 23, 2025
@hellais
Copy link
Member

hellais commented Jan 23, 2025

We should do this as part of OONI Run v2.1

@hellais hellais assigned LDiazN and unassigned bassosimone Jan 23, 2025
@hellais hellais moved this to Sprint Backlog in Roadmap Jan 23, 2025
@hellais hellais moved this from Sprint Backlog to Backlog in Roadmap Jan 23, 2025
@hellais hellais removed this from Roadmap Jan 29, 2025
@hellais hellais added priority/low Nice to have and removed priority/medium Normal priority issue labels Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup There's need to cleanup stuff a bit enhancement New feature request or improvement to existing functionality funder/drl2022-2024 ooni/probe-engine priority/low Nice to have technical task technical tasks e.g. deployment
Projects
None yet
Development

No branches or pull requests

3 participants