Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

android: butterknife is deprecated #1709

Closed
37 of 38 tasks
bassosimone opened this issue Jul 7, 2021 · 1 comment · Fixed by ooni/probe-android#618
Closed
37 of 38 tasks

android: butterknife is deprecated #1709

bassosimone opened this issue Jul 7, 2021 · 1 comment · Fixed by ooni/probe-android#618
Assignees
@aanorbel
Labels
bug Something isn't working correctly platform/android priority/low Nice to have

Comments

@bassosimone
Copy link
Contributor

bassosimone commented Jul 7, 2021 •
edited by aanorbel
Loading

See JakeWharton/butterknife@574ed28.

We should now use view binding.

Component to migrate.

  • CustomWebsiteActivity
  • InfoActivity
  • MainActivity
  • MeasurementDetailActivity
  • OoniRunActivity.java
  • OverviewActivity.java
  • ResultDetailActivity
  • RunningActivity
  • TextActivity
  • DashboardFragment
  • ProgressFragment
  • ResultListFragment
  • DashFragment
  • FacebookMessengerFragment
  • HeaderNdtFragment
  • HeaderOutcomeFragment
  • HttpHeaderFieldManipulationFragment
  • HttpInvalidRequestLineFragment
  • NdtFragment
  • PsiphonFragment
  • RiseupVPNFragment
  • SignalFragment
  • TelegramFragment
  • TorFragment
  • WebConnectivityFragment
  • WhatsappFragment
  • Onboarding1Fragment
  • Onboarding2Fragment
  • Onboarding3Fragment
  • OnboardingAutoTestFragment
  • OnboardingCrashFragment
  • OnboardingDialogPopquizFragment
  • OnboardingDialogWarningFragment
  • Update ResultHeaderDetailFragment #2526
  • ResultHeaderMiddleboxFragment
  • ResultHeaderPerformanceFragment
  • ResultHeaderTBAFragment
  • Remove com.jakewharton:butterknife:+ and any other reference Chore: Remove remaining references to butterknife probe-android#618
@bassosimone bassosimone added the bug Something isn't working correctly label Jul 7, 2021
@bassosimone bassosimone added the priority/low Nice to have label Aug 20, 2021
@bassosimone bassosimone removed this from the Sprint 46 - Happy Oyster milestone Aug 30, 2021
@hellais hellais assigned aanorbel and unassigned lorenzoPrimi Jan 31, 2022
@hellais
Copy link
Member

hellais commented Apr 18, 2022

We have decided to do this incrementally as we touch parts of the code that are using butterknife.

Some work has been done as part of the following PRs:

@aanorbel aanorbel mentioned this issue Apr 19, 2022
Merged
@bassosimone bassosimone removed their assignment Jun 13, 2022
This was referenced Aug 3, 2023
Merged
Merged
Merged
@aanorbel aanorbel mentioned this issue Aug 18, 2023
Merged
This was referenced Aug 26, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@aanorbel aanorbel mentioned this issue Sep 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aanorbel aanorbel

Labels
bug Something isn't working correctly platform/android priority/low Nice to have
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Chore: Remove remaining references to butterknife ooni/probe-android
4 participants
@bassosimone @hellais @lorenzoPrimi @aanorbel