Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Both Mobile and Desktop versions include RiseupVPN in Circumvention tests description #418

Open
sloncocs opened this issue Aug 9, 2022 · 4 comments
Assignees
Labels
priority/medium Normal priority issue

Comments

@sloncocs
Copy link

sloncocs commented Aug 9, 2022

Describe the bug

Both Mobile and Desktop versions include RiseupVPN in Circumvention tests description while the RiseupVPN test is temporarily disabled.

To Reproduce

Open Circumvention card in either OONI Probe Mobile or OONI Probe Desktop. Currently the following description of the card is presented:
"Check whether Psiphon, Tor or RiseupVPN are blocked."

Expected behaviour

Check whether Psiphon or Tor are blocked.

Screenshots

Screenshot 2022-08-09 at 10 39 14

System information (please complete the following information):

  • OONI Probe version: 3.7.0

Additional context

There is a concern that if we edit an original string in Transifex, we will lose all the translations of the same string. However, as the sentence's structure doesn't change and there are no words to translate (we either add or delete 'RiseupVPN'), I think we can manage to edit the translation to all languages by ourselves.

@sloncocs sloncocs added bug Something isn't working correctly priority/medium Normal priority issue labels Aug 9, 2022
@sloncocs sloncocs self-assigned this Aug 9, 2022
@sloncocs sloncocs removed the bug Something isn't working correctly label Dec 1, 2022
@sloncocs sloncocs removed their assignment Dec 1, 2022
@hellais hellais assigned sdsantos and aanorbel and unassigned sloncocs Jan 27, 2025
@hellais
Copy link
Member

hellais commented Jan 27, 2025

This is still an issue. Adding @aanorbel and @sdsantos

@sdsantos sdsantos transferred this issue from ooni/probe Jan 27, 2025
@sdsantos sdsantos moved this from Backlog to Sprint Backlog in Roadmap Jan 27, 2025
@aanorbel
Copy link
Member

Yes it is an issue

@sdsantos
Copy link
Collaborator

We need to update all string translations to remove that mention.

@hellais hellais removed this from Roadmap Jan 29, 2025
@hellais
Copy link
Member

hellais commented Jan 30, 2025

If this string is changed everybody will have to retranslate it. We can't do it as part of launch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/medium Normal priority issue
Projects
None yet
Development

No branches or pull requests

4 participants