Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry when ratelimited #1367

Closed
bjartek opened this issue Jan 31, 2024 · 5 comments
Closed

Retry when ratelimited #1367

bjartek opened this issue Jan 31, 2024 · 5 comments
Assignees
Labels
Feature A new user feature or a new package API Feedback

Comments

@bjartek
Copy link
Collaborator

bjartek commented Jan 31, 2024

Issue To Be Solved

When interacting through flow you have to now handle rate limits as the new limits are way more agressive then what they used to be. Having to modify client code to add that is quite the effort.

(Optional): Suggest A Solution

When interacting with the flow chain through flowkit it would be nice to be able to automatically retry requests that fail due to rate-limiting using set policies.

Would it be an option when creating a flowkit.State to add some policies for retrying, and have those only retry on 429.

This library for instance is really flexible around retry and it is not specific to http/grpc.

https://github.com/avast/retry-go

(Optional): Context

@bjartek bjartek added Feature A new user feature or a new package API Feedback labels Jan 31, 2024
@chasefleming
Copy link
Member

@bjartek is the rate limiting happening when you're using CLI commands or when you use flowkit in an application or library?

@bjartek
Copy link
Collaborator Author

bjartek commented Feb 8, 2024

Library. And it looks like you can configure a grpc client to retry. I just added a pr to flowkit to enable sending in dialopts.

@chasefleming
Copy link
Member

Awesome, yeah I was going to say maybe it should just be a config in flowkit then if it's at a library level.

@chasefleming
Copy link
Member

@bjartek can this be closed now?

@bjartek
Copy link
Collaborator Author

bjartek commented Feb 13, 2024

Yes

@bjartek bjartek closed this as completed Feb 13, 2024
@github-project-automation github-project-automation bot moved this to ✅ Done in 🌊 Flow 4D Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature A new user feature or a new package API Feedback
Projects
Archived in project
Development

No branches or pull requests

2 participants