-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FLIX Integration issues #1286
Comments
The description for FLIX command should be improved, it's now:
It should be something like:
I would also add a new super command for flix that can be something like
Using |
Another subjective opinion is we shouldn't just use the word FLIX everywhere because that is a made-up word and someone new coming to Flow will have no understanding of what it means. We should always explain what you can do, like execute common transactions or scripts. |
Another really improtant thing is it should work out of the box, now FLIX requires for you to have for example FungibleToken contract in your flow.json, this makes the whole process difficult, so if I have to add a new contract to flow.json to send 1 Flow I already have to know too much. |
the addresses does not have to be in your flow.json IIRC, they are fetched from one of the dependencies, but the emulator versions are probably not present here |
my flow.json here has no imports, no contracts. only the signer information. |
But the error message it gave me when I did not specify parameters could have been better, because it know what they are and the type. It could show that. |
Yeah I think if you define the network and signer you shouldn't have an issue and should require no dependencies (if you're not on emulator), but agree error messaging could be better. And maybe an error could be added about trying to use FLIX on emulator. The naming is a question more for @JeffreyDoyle, @bjartek , and @bthaile . |
I was just looking through the FLIX templates and I realized not all have at least So it's almost like there needs to be a check for the network you are trying to run and if the dependencies are no there for that network it needs to tell you that the FLIX cannot be run on this network. @JeffreyDoyle is there any plan to make it a requirement of a FLIX to have a minimum set of networks to be included? |
Networks are not hardcode, FLIX can support any network or no network. It depends on the user that generates them. The json file is self contained and does not depend on user's flow.json.
Local development, it is possible using FLIX, for core contracts. The user generating the FLIX json would need to add aliases to the core contract dependencies in their flow.json then generate a FLIX. This would work for core contracts. I can add emulator core contracts to the default core contracts in flixkit-go.
The bigger question: FlIX is meant for easy of integration and reuse. By nature this doesn't work with emulator outside of core contracts. Since other teams won't have the dependencies baked into their emulator. They would have to deploy other Team's contracts and generate their own version of FLIX to get the correct dependence addresses. I don't think we should promote using FLIX with emulator. Devs should focus on testnet and mainnet deployments and FLIX since that is the whole point of FLIX. |
Added warnings to docs to give more visibility to network dependencies. |
@bthaile I understand the FLIX power comes from using it on mainnet, and that's great, I also completely agree with the value proposition in making interactions secure. |
The FLIX doesn't work for very basic default setup using the Flow CLI and emulator. The experience should be that if you setup a new project and run an emulator it would be very easy to send some flow between accounts using FLIX, but now the output is:
We should also have more examples in the
flow flix execute
help section, maybe include most common interactions, the idea is you can discover things you can do without reading the docs. Another useful thing would be to update maybe the transaction help screen to include a line that says you can use FLIX for common operations.The text was updated successfully, but these errors were encountered: