Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distribute migration reports to a central location/URL #3265

Closed
jribbink opened this issue Apr 18, 2024 · 3 comments
Closed

Distribute migration reports to a central location/URL #3265

jribbink opened this issue Apr 18, 2024 · 3 comments
Assignees

Comments

@jribbink
Copy link
Contributor

jribbink commented Apr 18, 2024

Issue to be solved

In order for tooling to query the status of the last migration report, there must exist some central server/URL which hosts so that the latest migration report can always be found.

(specifically needed for onflow/flow-cli#1508)

Suggested Solution

Setup a pattern for uploading these to GCP, GitHub, or other so that they may be repeatably queried by tooling & the latest report will always be used.

@jribbink
Copy link
Contributor Author

jribbink commented Apr 18, 2024

I think we can probably just use GitHub for this & put the reports in this folder somewhere:

https://github.com/onflow/cadence/tree/e020944c7f187de8bf9bfc3b3293f32abb05510a/migrations_data

As long as we follow the same pattern each time, the CLI should be able to pick these up.

I'm thinking something like:

https://github.com/onflow/cadence/tree/master/migrations_data/raw_data/MM-DD-YYYY-NETWORK-TIMESTAMP.json

Where the CLI can choose the latest JSON (based on filename) for the given network of their choosing

@jribbink
Copy link
Contributor Author

jribbink commented Apr 19, 2024

I've created the PR for the CLI to fetch contract update statuses for the latest migration report onflow/flow-cli#1529.

Currently, the CLI assumes the following:

  • master branch of onflow/cadence
  • files live in migrations_data/raw/XXXXX-NETWORK-<unix-timestamp>.json (naming can be anything as long as it ends with NETWORK-<unix-timestamp>.json)

If an alternate format is preferred, I can update the PR accordingly. If this is acceptable we can try to merge this Flow CLI PR ASAP. I can't seem to find the JSON report for the last emulated migration, so I'm unable to make a PR for this myself, but if someone else could do this that would be awesome.

Thanks!

(cc @j1010001 )

@jribbink
Copy link
Contributor Author

closed by #3273

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants