Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test] Allow custom logger for the test runner #269

Closed
jribbink opened this issue Jan 2, 2024 · 0 comments · Fixed by #267
Closed

[Test] Allow custom logger for the test runner #269

jribbink opened this issue Jan 2, 2024 · 0 comments · Fixed by #267
Assignees

Comments

@jribbink
Copy link
Contributor

jribbink commented Jan 2, 2024

Issue to be solved

Currently, there is no way to provide a custom logger to the test runner and this defaults to stdio. This is problematic because sometimes developers may want to suppress, format, or display logs in a different way. (Currently, this is creating an issue in Flow CLI onflow/flow-cli#1324).

This is related to the bug encountered in #265

Suggested Solution

Add an additional builder function, WithLogger which allows the developer to specific a custom zerolog context. The default logger may either be stdio or suppressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant