Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose cryptography backend features in the omnibor crate #190

Closed
alilleybrinker opened this issue Aug 23, 2024 · 1 comment
Closed

Expose cryptography backend features in the omnibor crate #190

alilleybrinker opened this issue Aug 23, 2024 · 1 comment
Labels
crate: omnibor Relating to the omnibor crate type: feature New feature or request

Comments

@alilleybrinker
Copy link
Member

We've recently added support for additional cryptography backends (namely, BoringSSL and OpenSSL) in the gitoid crate, in addition to the already-included RustCrypto backend. However, those new backends aren't exposed in the omnibor crate, which means users of the OmniBOR crate are still limited to just RustCrypto.

These features should be exposed in the omnibor crate in the same way they are in the gitoid crate, in a new submodule for cryptography backends, and with crate features whose names match those in the gitoid crate.

Note that this does complicate conditional compilation flags, and requires testing more combinations. In particular, we'll need to add code, as there is in the gitoid crate, to cover the case that no cryptography backend is enabled at compile time.

@alilleybrinker
Copy link
Member Author

Resolved with the combination of the gitoid and omnibor crates.

@github-project-automation github-project-automation bot moved this from Backlog to Done in OmniBOR Rust Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crate: omnibor Relating to the omnibor crate type: feature New feature or request
Projects
Status: Done
Development

No branches or pull requests

1 participant