Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop pedestal dependency #31

Open
namenu opened this issue Jan 9, 2025 · 1 comment
Open

Drop pedestal dependency #31

namenu opened this issue Jan 9, 2025 · 1 comment

Comments

@namenu
Copy link

namenu commented Jan 9, 2025

[io.pedestal.interceptor :refer [interceptor]]

This ns has a pedestal dependency and therefore cannot be required by ring users.

Since maps are themselves an extension of the IntoInterceptor protocol, I suggest changing the inject-superlifter to return only data.

@oliyh
Copy link
Owner

oliyh commented Jan 9, 2025

Hi,

This makes sense, and there is an integration test with pedestal which will ensure it still works.

Will try to look at this soon.
Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants