Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature names inconsistent #86

Closed
ahwagner opened this issue Feb 16, 2018 · 2 comments
Closed

Feature names inconsistent #86

ahwagner opened this issue Feb 16, 2018 · 2 comments
Assignees

Comments

@ahwagner
Copy link
Collaborator

All records from BRCA exchange have a list under the feature_names attribute, other sources have a string or None object here. The list is never longer than one item, so I propose we fix the harvester to assign only string or None objects to the feature_names attribute.

Omitting the review label because this is a straightforward, quick fix.

@ahwagner ahwagner added the bug label Feb 16, 2018
@bwalsh
Copy link
Member

bwalsh commented Feb 21, 2018

Can we combine this with #88 ?
( affects the same area of the code )

@bwalsh
Copy link
Member

bwalsh commented Feb 22, 2018

done 2fd2e8e

@bwalsh bwalsh self-assigned this Feb 22, 2018
@bwalsh bwalsh added the fixed label Feb 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants