You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The logo and the offspot name must be sourced from env-provided information (already used in other places in the offspot) ; fallback is supposed to already be handled there, but it is still nice to have a fallback of the fallback (especially for local development)
The fallback has "odd boundaries" + is an SVG. @rgaudin could you develop what you mean by odd boundaries + should we simply use a PNG as this is what will be provided in env-provided information anyway?
The text was updated successfully, but these errors were encountered:
See the size of the canvas? Browsers look for first path and display it directly so it doesn't add empty vertical space in your UI but should it be directly converted to PNG, you'd get a huge space above/below your logo which is not what you'd expect.
As it's meant to be replaced, it's better to trim it to used dimensions.
And yes, it should be a PNG because that's what will be used in offspot context so UI should be prepared for it. Btw if not already the case, you should constraint this image as it is user-provided. We're waiting for @Simsie to provide guidance on recommended or enforced dimensions
This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.
From #58 (review) and #58 (comment)
The logo and the offspot name must be sourced from env-provided information (already used in other places in the offspot) ; fallback is supposed to already be handled there, but it is still nice to have a fallback of the fallback (especially for local development)
The fallback has "odd boundaries" + is an SVG. @rgaudin could you develop what you mean by odd boundaries + should we simply use a PNG as this is what will be provided in env-provided information anyway?
The text was updated successfully, but these errors were encountered: