Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend: fix logo and offspot name #64

Open
benoit74 opened this issue Dec 14, 2023 · 3 comments
Open

Frontend: fix logo and offspot name #64

benoit74 opened this issue Dec 14, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request stale
Milestone

Comments

@benoit74
Copy link
Collaborator

image

From #58 (review) and #58 (comment)

The logo and the offspot name must be sourced from env-provided information (already used in other places in the offspot) ; fallback is supposed to already be handled there, but it is still nice to have a fallback of the fallback (especially for local development)

The fallback has "odd boundaries" + is an SVG. @rgaudin could you develop what you mean by odd boundaries + should we simply use a PNG as this is what will be provided in env-provided information anyway?

@benoit74 benoit74 added this to the v0.2 milestone Dec 14, 2023
@benoit74 benoit74 added the enhancement New feature or request label Dec 14, 2023
@benoit74 benoit74 self-assigned this Dec 14, 2023
@benoit74 benoit74 mentioned this issue Dec 14, 2023
@rgaudin
Copy link
Member

rgaudin commented Dec 14, 2023

Screenshot 2023-12-14 at 09 28 09

See the size of the canvas? Browsers look for first path and display it directly so it doesn't add empty vertical space in your UI but should it be directly converted to PNG, you'd get a huge space above/below your logo which is not what you'd expect.

As it's meant to be replaced, it's better to trim it to used dimensions.

And yes, it should be a PNG because that's what will be used in offspot context so UI should be prepared for it. Btw if not already the case, you should constraint this image as it is user-provided. We're waiting for @Simsie to provide guidance on recommended or enforced dimensions

@benoit74
Copy link
Collaborator Author

Postponing this to 2.0, this is probably not urgent / mandatory, only #93 is probably sufficient for 1.0

@benoit74 benoit74 modified the milestones: 0.2.0, 2.0.0 Jan 16, 2024
Copy link

stale bot commented Mar 16, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

@stale stale bot added the stale label Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request stale
Projects
None yet
Development

No branches or pull requests

2 participants