Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra associated data in 'Commit search' page #11

Open
benmandrew opened this issue Jun 29, 2023 · 0 comments
Open

Extra associated data in 'Commit search' page #11

benmandrew opened this issue Jun 29, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@benmandrew
Copy link
Collaborator

It would be useful to have more information associated with each job, for example:

  • Running time (end_time - start_time)
  • Job status, e.g. waiting to start, started running, failed

Other fields can be requested in comments below.

Current system

The commit search page is currently backed by a database with the following schema:

ci_build_index (
  label  TEXT NOT NULL,
  hash   TEXT NOT NULL,
  job_id TEXT NOT NULL,
  PRIMARY KEY (label, hash, job_id)
)

where job_id is for example linux-arm64-5.0, encoding the OS, architecture, and OCaml version of the job.

On job creation a database record is immediately entered into ci_build_index. We have no current way of modifying existing records, making changing data like those detailed above more difficult to keep in sync.

What would be required

  1. A database migration system would be required to change the deployed DB schema to the one desired. This system already exists in index.ml of ocurrent/ocaml-ci.
  2. DB queries would have to be written to be able to update records.
  3. At all points in the code where relevent job events occur, the right DB queries would have to be run. If any are missed then the in-memory and database state could fall out of sync.
@benmandrew benmandrew added the enhancement New feature or request label Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant