Bench old commits #482
Closed
Bench old commits #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElectreAAS
force-pushed
the
bench-old-commits
branch
from
fb50434 to
bd9d3e5
Compare
art-w
reviewed
Nov 29, 2023
|
Thanks! This was a much awaited feature! A couple of thoughts which prevents this from going live:
|
I have no idea
I also have no idea, but it seems testable. I don't have time to allocate to this nowadays, but someone else could.
This PR does not take that scenario into account. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #379.
pipeline/lib/commits.mlcontains the important part: the actual git command to run to traverse the commit history.pipeline/libs/models.ml[i]contains the necessary two new functions that query the database, to make sure we don't benchmark twice the same commit.Note: This PR requires some changes to the API of ocurrent (namely this PR: ocurrent/ocurrent#442), and hence is in draft mode to make sure it doesn't get merged before the PR on ocurrent is properly reviewed.It is, however, ready to be reviewed in the current-bench context. The API changes in ocurrent are trivials from our point of view.
Edit: ocurrent/ocurrent#442 has been merged, this is ready for review