Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Flatpak support + Flathub #1461

Open
PunkPangolin opened this issue Jan 15, 2025 · 7 comments
Open

[Feature]: Flatpak support + Flathub #1461

PunkPangolin opened this issue Jan 15, 2025 · 7 comments
Assignees

Comments

@PunkPangolin
Copy link

Describe the proposed feature

I made a manifest to build OCRmyPDF as a flatpak (see here). I would like to get it accepted on FlatHub (although I am not sure how exactly they deal with CLI applications).

Would you be okay with that (FlatHub actually requires contacting upstream on that)? And would you like to take part as a maintainer?

For the metainfo.xml file, I took the data from pyproject.toml and used author id=io.github.jbarlow83, is that fine for you, or would you prefer something like OCRmyPDF Developers?

I don't know if you are familiar with flatpak packaging and/or FlatHub, please have no hesitation to ask any questions.

@jbarlow83
Copy link
Collaborator

Yes, if you are able to do this I would much appreciate it.

Use ocrmypdf.io or io.ocrmypdf for a domain name or reverse domain name. I own that domain, although it's not doing anything and I don't have an email tied to that. OCRmyPDF Developers works fine as well.

@github-actions github-actions bot removed the triage Issue needs triage label Jan 15, 2025
@PunkPangolin
Copy link
Author

Thank you for the prompt response! I am glad I can finally do something to support OCRmyPDF.

Then I would use io.ocrmypdf.ocrmypdf as application ID and io.ocrmypdf as author ID according to FlatHub guidelines ({tld}.{vendor}.{product}). As the website is not used for anything, this might require some kind of verification in the admission process.

FlatHub would also prefer the metainfo.xml file to be part of upstream. Would that work for you? Besides adding new releases in, this should not result in any additional work.

Finally, would you like to be added as a maintainer?

@jbarlow83
Copy link
Collaborator

I can be maintainer, but would you be willing to also be listed as a maintainer?

Put any changes you need in a PR.

I can make io.ocrmypdf redirect to the github page, or does it need a landing page of some sort?

@PunkPangolin
Copy link
Author

Yes, I am also willing to be listed as a maintainer and would be happy to assist the project in this way.

I think the only helpful upstream change would be the metainfo file, for which I made a PR for in #1462

Linking ocrmypdf.io to the GitHub page should be enough to get it accepted, for verification there maybe have to be a token placed (see documentation).

@PunkPangolin
Copy link
Author

I made a PR for submission to Flathub [here](flathub/flathub#6035. The flaws regarding manifest and metadata should be sorted out (hopefully).
Now only the verification of domain ownership remains. For that, forwarding to the GitHub repo should be enough.

@v4u6h4n
Copy link

v4u6h4n commented Jan 23, 2025

Could the flatpak be built with leptonica so --remove-background could be reimplemented?

@PunkPangolin
Copy link
Author

PunkPangolin commented Jan 23, 2025

The flatpak build already includes leptonica, but --remove-background not working cannot be fixed by packaging, as it is no longer implemented by upstream (see here).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants