Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for BMI and height to be ranges #11

Open
4 of 14 tasks
wleoncio opened this issue Jan 24, 2025 · 2 comments
Open
4 of 14 tasks

Allow for BMI and height to be ranges #11

wleoncio opened this issue Jan 24, 2025 · 2 comments
Assignees

Comments

@wleoncio
Copy link
Member

wleoncio commented Jan 24, 2025

This should also make calculation of the confidence intervals (#9) easier.

Test with one example (simple FX, vo2_ml_kg_min):

  • Group $\beta$s in matrices, lists, whatever works best (1 per group)
  • Calculate weighted.mean() without relying on apply().
  • Calculate $y$ as a function of the new beta and x
  • Make sure new output match the ones from v1.0.0.9001
  • Allow $X$ to (internally) be a $k \times p$ matrix, where $p$ is the number of parameters and $k$ is the number of observations
  • Allow input to be a range of $k$ observations for height and BMI
  • Make sure new output match the ones from v1.0.0.9001

Generalize to all others:

  • Group $\beta$s in matrices, lists, whatever works best (1 per group)
  • Calculate weighted.mean() without relying on apply().
  • Calculate $y$ as a function of the new beta and x
  • Make sure new output match the ones from v1.0.0.9001
  • Allow $X$ to be a $k \times p$ matrix, where $p$ is the number of parameters and $k$ is the number of observations
  • Allow input to be a range of $k$ observations for height and BMI
  • Make sure new output match the ones from v1.0.0.9001
@wleoncio wleoncio self-assigned this Jan 24, 2025
@wleoncio
Copy link
Member Author

Reference values from v0.0.0.9002:

Image

wleoncio added a commit that referenced this issue Jan 24, 2025
wleoncio added a commit that referenced this issue Jan 24, 2025
wleoncio added a commit that referenced this issue Jan 24, 2025
* issue-11:
  Updated NEWS.md
  Calculating `y` without `lapply()` (#11)
  Testing `beta_hat` as a group field (#11)
  Updated metadata
  Bumped version
  Moved classes and groups to own files
wleoncio added a commit that referenced this issue Jan 24, 2025
Others won't be fixed because the result doesn't change, and all
formulas will be changed anyway for #11.
@wleoncio
Copy link
Member Author

See #4 (comment) for tips on object sizes.

wleoncio added a commit that referenced this issue Jan 24, 2025
wleoncio added a commit that referenced this issue Jan 24, 2025
wleoncio added a commit that referenced this issue Jan 24, 2025
wleoncio added a commit that referenced this issue Jan 24, 2025
* issue-11:
  Added FIXME (#11)
  Generalized expansion of `x` (#11)
  Extracted function to calculate `y` (#11)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant